diff --git a/Digitisers/SimpleDigi/src/PlanarDigiAlg.cpp b/Digitisers/SimpleDigi/src/PlanarDigiAlg.cpp index 2a4ee084e..973a55628 100644 --- a/Digitisers/SimpleDigi/src/PlanarDigiAlg.cpp +++ b/Digitisers/SimpleDigi/src/PlanarDigiAlg.cpp @@ -259,7 +259,7 @@ StatusCode PlanarDigiAlg::execute() localPointSmeared.setY( localPoint.y() + dy ); //check if hit is in boundaries - if ( ms->isLocalInBoundary( localPointSmeared ) && fabs(dx)<_maxPull*resU && fabs(dy)<_maxPull*resV ) { + if ( ms->isLocalInBoundary( localPointSmeared ) && fabs(dx)<=_maxPull*resU && fabs(dy)<=_maxPull*resV ) { //if ( ms->isLocalInBoundary( localPointSmeared ) ) { accept_hit = true; break; diff --git a/Examples/options/sim-rec-trackerecal.py b/Examples/options/sim-rec-trackerecal.py index 1117e414a..c3a8f6d68 100644 --- a/Examples/options/sim-rec-trackerecal.py +++ b/Examples/options/sim-rec-trackerecal.py @@ -79,7 +79,7 @@ from Configurables import GearSvc gearsvc = GearSvc("GearSvc") -gearsvc.GearXMLFile = "Detector/DetCEPCv4/compact/FullDetGear.xml" +#gearsvc.GearXMLFile = "Detector/DetCEPCv4/compact/FullDetGear.xml" from Configurables import TrackSystemSvc tracksystemsvc = TrackSystemSvc("TrackSystemSvc") @@ -331,7 +331,7 @@ TopAlg = [genalg, detsimalg, digiVXD, digiSIT, digiSET, digiFTD, spSIT, spFTD, digiTPC, clupatra, tracking, forward, subset, full, simHitMerge, caloDigi, pandoralg, write], EvtSel = 'NONE', EvtMax = 10, - ExtSvc = [rndmengine, dsvc, evtseeder, gearsvc, geosvc, tracksystemsvc], + ExtSvc = [rndmengine, dsvc, evtseeder, geosvc, gearsvc, tracksystemsvc], HistogramPersistency='ROOT', OutputLevel=INFO ) diff --git a/Reconstruction/Tracking/src/Clupatra/clupatra_new.cpp b/Reconstruction/Tracking/src/Clupatra/clupatra_new.cpp index 9ecee5641..6ff24484f 100644 --- a/Reconstruction/Tracking/src/Clupatra/clupatra_new.cpp +++ b/Reconstruction/Tracking/src/Clupatra/clupatra_new.cpp @@ -287,7 +287,8 @@ namespace clupatra_new{ UTIL::BitField64 encoder( UTIL::ILDCellID0::encoder_string ) ; encoder[UTIL::ILDCellID0::subdet] = UTIL::ILDDetID::TPC ; - edm4hep::TrackerHit firstHit; // = 0 ; + edm4hep::TrackerHit firstHit = 0; + // = 0 equal to unlink() //firstHit.unlink(); IMarlinTrack* bwTrk = 0 ; diff --git a/Reconstruction/Tracking/src/FullLDCTracking/FullLDCTrackingAlg.cpp b/Reconstruction/Tracking/src/FullLDCTracking/FullLDCTrackingAlg.cpp index fad902455..ee5f1feb2 100755 --- a/Reconstruction/Tracking/src/FullLDCTracking/FullLDCTrackingAlg.cpp +++ b/Reconstruction/Tracking/src/FullLDCTracking/FullLDCTrackingAlg.cpp @@ -1166,13 +1166,18 @@ void FullLDCTrackingAlg::prepareVectors() { trackExt->setNDF(tpcTrack.getNdf()); trackExt->setChi2(tpcTrack.getChi2()); for (int iHit=0;iHitsecond; + if (it==mapTrackerHits.end()) { + error() << "Cannot find hit " << hit.id() << " in map" << endmsg; + continue; + } + TrackerHitExtended* hitExt = it->second; //info() << hit.id() << " " << hitExt << endmsg; hitExt->setTrackExtended( trackExt ); trackExt->addTrackerHitExtended( hitExt ); @@ -1231,8 +1236,17 @@ void FullLDCTrackingAlg::prepareVectors() { char strg[200]; HelixClass helixSi; for (int iHit=0;iHitsecond; hitExt->setTrackExtended( trackExt ); trackExt->addTrackerHitExtended( hitExt ); @@ -1534,8 +1548,8 @@ TrackExtended * FullLDCTrackingAlg::CombineTracks(TrackExtended * tpcTrack, Trac int nTPCHits = int(tpcHitVec.size()); int nHits = nTPCHits + nSiHits; - //std::cout << "FullLDCTrackingAlg::CombineTracks nSiHits = " << nSiHits << endmsg; - //std::cout << "FullLDCTrackingAlg::CombineTracks nTPCHits = " << nTPCHits << endmsg; + //debug() << "FullLDCTrackingAlg::CombineTracks nSiHits = " << nSiHits << endmsg; + //debug() << "FullLDCTrackingAlg::CombineTracks nTPCHits = " << nTPCHits << endmsg; TrackerHitVec trkHits; trkHits.reserve(nHits); @@ -1748,7 +1762,7 @@ TrackExtended * FullLDCTrackingAlg::CombineTracks(TrackExtended * tpcTrack, Trac tpcHitInFit.push_back(tpcHitVec[i]); } } - + debug() << "FullLDCTrackingAlg::CombineTracks: Check for Silicon Hit rejections ... " << endmsg; if ( (int)siOutliers.size() > _maxAllowedSiHitRejectionsForTrackCombination ) {