Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dia data layer to benchmarks #47

Merged
merged 4 commits into from
Oct 30, 2023
Merged

Add dia data layer to benchmarks #47

merged 4 commits into from
Oct 30, 2023

Conversation

Ericgig
Copy link
Member

@Ericgig Ericgig commented Oct 24, 2023

  • Add benchmark for DIA.
  • Run steadystate test with CSR instead of DIA.
  • Remove the return from benchmark functions. Recent pytest raise a warning.

hodgestar
hodgestar reviewed Oct 26, 2023
View reviewed changes
Copy link
Contributor

@hodgestar hodgestar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions about some changes I didn't immediately understand. Otherwise looks good.

qutip_benchmark/benchmarks/bench_solvers.py Outdated Show resolved Hide resolved
qutip_benchmark/benchmarks/bench_solvers.py Outdated
H, _, c_ops, _ = cavity_setup(size)
# Steadystate is bad with Dia.
H = H.to("csr")
c_ops = [c_ops[0].to("csr")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And similar question here about the .to("csr").

@Ericgig
Copy link
Member Author

Ericgig commented Oct 27, 2023

I opened #48 for the steadystate issue and reverted those changes here.

@Ericgig Ericgig merged commit 7067a06 into qutip:master Oct 30, 2023
2 checks passed
@Ericgig Ericgig deleted the add_Dia branch October 30, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hodgestar hodgestar hodgestar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ericgig @hodgestar