Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support dynamic URIs (or metadata) #244

Closed
drernie opened this issue Sep 25, 2024 · 1 comment · Fixed by #248
Closed

support dynamic URIs (or metadata) #244

drernie opened this issue Sep 25, 2024 · 1 comment · Fixed by #248

Comments

@drernie
Copy link
Member

drernie commented Sep 25, 2024

  • scrape the actual publishDir -- capture when Path is created?
  • add metadata field to the quilt config
@drernie
Copy link
Member Author

drernie commented Sep 25, 2024

Ah! We can scrape this from the PKGS cache, as all URIs are sent to QuiltPackage.forParsed before QuiltObserver - onFilePublish

That should allow us to get rid of all the params scraping, making it simpler and more robust.

@drernie drernie linked a pull request Oct 11, 2024 that will close this issue
feat(244) dynamic uris #248
Merged
@drernie drernie mentioned this issue Oct 11, 2024
Merged
drernie added a commit that referenced this issue Oct 24, 2024
@drernie
feat(244) dynamic uris (#248)
847d29f 
#244

---------

Co-authored-by: Dr. Ernie Prabhakar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(244) dynamic uris quiltdata/nf-quilt
1 participant
@drernie