Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add types #7

Closed
drernie opened this issue Aug 24, 2024 · 2 comments · Fixed by #8
Closed

add types #7

drernie opened this issue Aug 24, 2024 · 2 comments · Fixed by #8
Assignees
@drernie

Comments

@drernie
Copy link
Member

drernie commented Aug 24, 2024

federator/data_source.py:4: error: Skipping analyzing "athena_federation.athena_data_source": module is installed, but missing library stubs or py.typed marker [import-untyped]
federator/handler.py:4: error: Skipping analyzing "athena_federation.lambda_handler": module is installed, but missing library stubs or py.typed marker [import-untyped]
@drernie
Copy link
Member Author

drernie commented Aug 24, 2024

Add file for py.typed

Fix type of records to dict[str, List]

Move helpers from federator?

  • from_rows
  • from_table

@drernie
Copy link
Member Author

drernie commented Aug 24, 2024

ReadCSV
ReadFile
TryFile

@drernie drernie self-assigned this Aug 24, 2024
@drernie drernie linked a pull request Aug 24, 2024 that will close this issue
7 add types #8
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drernie drernie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

7 add types quiltdata/athena-federation-python-sdk
1 participant
@drernie