From ee6537f5cb360f6ea1b6cad472dbaef0f15cebc9 Mon Sep 17 00:00:00 2001
From: Maciej Bodek <maciej.bodek@gmail.com>
Date: Fri, 29 Nov 2024 13:08:03 +0100
Subject: [PATCH] Implement zoom to data

---
 packages/browser-tests/questdb                |  2 +-
 .../src/scenes/Editor/Metrics/graph.tsx       | 65 ++++++++++++++---
 .../src/scenes/Editor/Metrics/index.tsx       | 35 ++-------
 .../src/scenes/Editor/Metrics/metric.tsx      | 73 +++++++++++++++++--
 .../src/scenes/Editor/Metrics/queries.ts      | 21 ++++++
 .../src/scenes/Editor/Metrics/utils.ts        | 14 +---
 6 files changed, 155 insertions(+), 55 deletions(-)

diff --git a/packages/browser-tests/questdb b/packages/browser-tests/questdb
index 8b2df2ba3..550f13627 160000
--- a/packages/browser-tests/questdb
+++ b/packages/browser-tests/questdb
@@ -1 +1 @@
-Subproject commit 8b2df2ba31ff20d86c3e2b9d71fa874972028729
+Subproject commit 550f1362790c0502d54193573c8a0dc1a85c6670
diff --git a/packages/web-console/src/scenes/Editor/Metrics/graph.tsx b/packages/web-console/src/scenes/Editor/Metrics/graph.tsx
index a468b671d..600c2b2a8 100644
--- a/packages/web-console/src/scenes/Editor/Metrics/graph.tsx
+++ b/packages/web-console/src/scenes/Editor/Metrics/graph.tsx
@@ -44,6 +44,40 @@ const GraphWrapper = styled(Box).attrs({
   align: "center",
 })`
   padding: 1rem 0;
+
+  .graph-no-data {
+    position: absolute;
+    display: flex;
+    flex-direction: column;
+    gap: 1rem;
+    width: 100%;
+    left: 50%;
+    top: 50%;
+    transform: translate(-50%, -50%);
+    width: 100%;
+    text-align: center;
+  }
+
+  .graph-no-data-text {
+    color: ${({ theme }) => theme.color.gray2};
+    font-size: 1.4rem;
+    text-align: center;
+  }
+
+  .graph-no-data-button {
+    align-self: center;
+    background-color: ${({ theme }) => theme.color.selection};
+    border: none;
+    color: ${({ theme }) => theme.color.foreground};
+    border-radius: 0.4rem;
+    height: 3rem;
+    padding: 0 1rem;
+    cursor: pointer;
+
+    &:hover {
+      background-color: ${({ theme }) => theme.color.comment};
+    }
+  }
 `
 
 const Label = styled.div`
@@ -63,21 +97,25 @@ type Props = {
   beforeLabel?: React.ReactNode
   loading?: boolean
   data: uPlot.AlignedData
+  canZoomToData?: boolean
   colors: string[]
   duration: MetricDuration
   yValue: (rawValue: number) => string
   actions?: React.ReactNode
+  onZoomToData?: () => void
 }
 
 export const Graph = ({
   label,
   beforeLabel,
   data,
+  canZoomToData,
   colors,
   duration,
   yValue,
   loading,
   actions,
+  onZoomToData,
 }: Props) => {
   const timeRef = useRef(null)
   const valueRef = useRef(null)
@@ -134,16 +172,25 @@ export const Graph = ({
             uPlotRef.current = uplot
             if (data[0].length === 0) {
               const noData = document.createElement("div")
-              noData.innerText = "No data available for this period"
-              noData.style.position = "absolute"
-              noData.style.left = "50%"
-              noData.style.top = "50%"
-              noData.style.transform = "translate(-50%, -50%)"
-              noData.style.color = theme.color.gray2
-              noData.style.fontSize = "1.2rem"
-              noData.style.width = "100%"
-              noData.style.textAlign = "center"
+              noData.className = "graph-no-data"
               uplot.over.appendChild(noData)
+
+              const noDataText = document.createElement("span")
+              noDataText.innerText = "No data available for this period"
+              noDataText.className = "graph-no-data-text"
+              noData.appendChild(noDataText)
+
+              if (canZoomToData) {
+                const zoomToDataButton = document.createElement("button")
+                zoomToDataButton.className = "graph-no-data-button"
+                zoomToDataButton.innerText = "Zoom to data"
+                zoomToDataButton.onclick = () => {
+                  if (onZoomToData) {
+                    onZoomToData()
+                  }
+                }
+                noData.appendChild(zoomToDataButton)
+              }
             }
           }}
         />
diff --git a/packages/web-console/src/scenes/Editor/Metrics/index.tsx b/packages/web-console/src/scenes/Editor/Metrics/index.tsx
index 64c78ca1a..d75a8f049 100644
--- a/packages/web-console/src/scenes/Editor/Metrics/index.tsx
+++ b/packages/web-console/src/scenes/Editor/Metrics/index.tsx
@@ -197,36 +197,10 @@ export const Metrics = () => {
           <Select
             name="duration"
             value={metricDuration}
-            options={[
-              {
-                label: formatDurationLabel(MetricDuration.ONE_HOUR),
-                value: MetricDuration.ONE_HOUR,
-              },
-              {
-                label: formatDurationLabel(MetricDuration.THREE_HOURS),
-                value: MetricDuration.THREE_HOURS,
-              },
-              {
-                label: formatDurationLabel(MetricDuration.SIX_HOURS),
-                value: MetricDuration.SIX_HOURS,
-              },
-              {
-                label: formatDurationLabel(MetricDuration.TWELVE_HOURS),
-                value: MetricDuration.TWELVE_HOURS,
-              },
-              {
-                label: formatDurationLabel(MetricDuration.TWENTY_FOUR_HOURS),
-                value: MetricDuration.TWENTY_FOUR_HOURS,
-              },
-              {
-                label: formatDurationLabel(MetricDuration.THREE_DAYS),
-                value: MetricDuration.THREE_DAYS,
-              },
-              {
-                label: formatDurationLabel(MetricDuration.SEVEN_DAYS),
-                value: MetricDuration.SEVEN_DAYS,
-              },
-            ]}
+            options={Object.values(MetricDuration).map((duration) => ({
+              label: formatDurationLabel(duration),
+              value: duration,
+            }))}
             onChange={(e) =>
               setMetricDuration(e.target.value as MetricDuration)
             }
@@ -260,6 +234,7 @@ export const Metrics = () => {
                 onRemove={handleRemoveMetric}
                 onTableChange={handleTableChange}
                 onColorChange={handleColorChange}
+                onMetricDurationChange={setMetricDuration}
               />
             ))}
       </Charts>
diff --git a/packages/web-console/src/scenes/Editor/Metrics/metric.tsx b/packages/web-console/src/scenes/Editor/Metrics/metric.tsx
index 8bac11962..f36dbf91a 100644
--- a/packages/web-console/src/scenes/Editor/Metrics/metric.tsx
+++ b/packages/web-console/src/scenes/Editor/Metrics/metric.tsx
@@ -7,14 +7,21 @@ import React, {
 } from "react"
 import { Metric as MetricItem } from "../../../store/buffers"
 import {
+  durationInMinutes,
   MetricDuration,
   MetricType,
   Latency,
   RowsApplied,
   metricTypeLabel,
+  LastNotNull,
 } from "./utils"
 import { QuestContext } from "../../../providers"
-import { latency as latencySQL, rowsApplied as rowsAppliedSQL } from "./queries"
+import {
+  latency as latencySQL,
+  rowsApplied as rowsAppliedSQL,
+  latencyLastNotNull as latencyLasNotNullSQL,
+  rowsAppliedLastNotNull as rowsAppliedLastNotNullSQL,
+} from "./queries"
 import * as QuestDB from "../../../utils/questdb"
 import { Graph } from "./graph"
 import uPlot from "uplot"
@@ -23,11 +30,11 @@ import { Box, Button, ForwardRef, Popover } from "@questdb/react-components"
 import { Error, Palette, Trash } from "@styled-icons/boxicons-regular"
 import { useSelector } from "react-redux"
 import { selectors } from "../../../store"
-import isEqual from "lodash.isequal"
 import { useLocalStorage } from "../../../providers/LocalStorageProvider"
 import { TableSelector } from "./table-selector"
 import { IconWithTooltip } from "../../../components/IconWithTooltip"
 import { ColorPalette } from "./color-palette"
+import { subMinutes } from "date-fns"
 
 const MetricInfoRoot = styled(Box).attrs({
   align: "center",
@@ -79,16 +86,19 @@ export const Metric = ({
   onRemove,
   onTableChange,
   onColorChange,
+  onMetricDurationChange,
 }: {
   metric: MetricItem
   metricDuration: MetricDuration
   onRemove: (metric: MetricItem) => void
   onTableChange: (metric: MetricItem, tableId: number) => void
   onColorChange: (metric: MetricItem, color: string) => void
+  onMetricDurationChange: (duration: MetricDuration) => void
 }) => {
   const { quest } = useContext(QuestContext)
   const [loading, setLoading] = useState(false)
   const [data, setData] = useState<uPlot.AlignedData>()
+  const [lastNotNull, setLastNotNull] = useState<number>()
   const [colorPickerOpen, setColorPickerOpen] = useState(false)
   const metricDurationRef = useRef(metricDuration)
 
@@ -99,6 +109,10 @@ export const Metric = ({
 
   const { autoRefreshTables } = useLocalStorage()
 
+  const minuteDurations: [MetricDuration, number][] = Object.entries(
+    durationInMinutes,
+  ) as [MetricDuration, number][]
+
   const fetchLatency = async () => {
     if (!metric.tableId) return Promise.reject()
     return quest.query<Latency>(
@@ -106,6 +120,11 @@ export const Metric = ({
     )
   }
 
+  const fetchLatencyLastNotNull = async () => {
+    if (!metric.tableId) return Promise.reject()
+    return quest.query<LastNotNull>(latencyLasNotNullSQL(metric.tableId))
+  }
+
   const fetchRowsApplied = async () => {
     if (!metric.tableId) return Promise.reject()
     return quest.query<RowsApplied>(
@@ -113,22 +132,45 @@ export const Metric = ({
     )
   }
 
+  const fetchRowsAppliedLastNotNull = async () => {
+    if (!metric.tableId) return Promise.reject()
+    return quest.query<LastNotNull>(rowsAppliedLastNotNullSQL(metric.tableId))
+  }
+
   const fetchers = {
     [MetricType.LATENCY]: fetchLatency,
     [MetricType.ROWS_APPLIED]: fetchRowsApplied,
     [MetricType.WRITE_AMPLIFICATION]: fetchRowsApplied,
   }
 
+  const fetchersLastNotNull = {
+    [MetricType.LATENCY]: fetchLatencyLastNotNull,
+    [MetricType.ROWS_APPLIED]: fetchRowsAppliedLastNotNull,
+    [MetricType.WRITE_AMPLIFICATION]: fetchRowsAppliedLastNotNull,
+  }
+
   const fetchMetric = async () => {
     setLoading(true)
     try {
-      const response = await fetchers[metric.metricType]()
-      if (response && response.type === QuestDB.Type.DQL) {
+      const responses = await Promise.all<
+        | QuestDB.QueryResult<RowsApplied>
+        | QuestDB.QueryResult<Latency>
+        | QuestDB.QueryResult<LastNotNull>
+      >([
+        fetchers[metric.metricType](),
+        fetchersLastNotNull[metric.metricType](),
+      ])
+
+      if (responses[0] && responses[0].type === QuestDB.Type.DQL) {
         const alignedData = graphDataConfigs[metric.metricType].getData(
-          response.data as any,
+          responses[0].data as any,
         )
         setData(alignedData)
       }
+      if (responses[1] && responses[1].type === QuestDB.Type.DQL) {
+        const lastNotNull = responses[1].data[0] as LastNotNull
+        setLastNotNull(new Date(lastNotNull.created).getTime())
+      }
     } catch (err) {
       console.error(err)
     } finally {
@@ -136,6 +178,17 @@ export const Metric = ({
     }
   }
 
+  const handleZoomToData = () => {
+    if (lastNotNull) {
+      const durationsWithData = minuteDurations.filter(
+        (d) => lastNotNull >= subMinutes(new Date(), d[1]).getTime(),
+      )
+      if (durationsWithData.length) {
+        onMetricDurationChange(durationsWithData[0][0])
+      }
+    }
+  }
+
   useEffect(() => {
     metricDurationRef.current = metricDuration
     if (metric.tableId) {
@@ -181,9 +234,19 @@ export const Metric = ({
 
   const tableName = tables.find((t) => t.id === metric.tableId)?.table_name
 
+  const canZoomToData = lastNotNull
+    ? lastNotNull >=
+      subMinutes(
+        new Date(),
+        minuteDurations[minuteDurations.length - 1][1],
+      ).getTime()
+    : false
+
   return (
     <Graph
       data={metric.tableId && data ? data : [[], []]}
+      canZoomToData={canZoomToData}
+      onZoomToData={handleZoomToData}
       colors={[metric.color]}
       loading={loading}
       duration={metricDuration}
diff --git a/packages/web-console/src/scenes/Editor/Metrics/queries.ts b/packages/web-console/src/scenes/Editor/Metrics/queries.ts
index b962b2c9a..49640b041 100644
--- a/packages/web-console/src/scenes/Editor/Metrics/queries.ts
+++ b/packages/web-console/src/scenes/Editor/Metrics/queries.ts
@@ -32,6 +32,17 @@ and created < date_trunc('minute', now())
 sample by ${sampleBy ?? mappedSampleBy[metricDuration]}`
 }
 
+export const rowsAppliedLastNotNull = (id: number) => `
+select
+  created
+from ${TelemetryTable.WAL}
+where tableId = ${id} 
+and event = 105
+and rowCount != null
+and physicalRowCount != null
+limit -1
+`
+
 export const latency = (
   id: number,
   metricDuration: MetricDuration,
@@ -53,3 +64,13 @@ and created < date_trunc('minute', now())
 sample by ${sampleBy ?? mappedSampleBy[metricDuration]}
 `
 }
+
+export const latencyLastNotNull = (id: number) => `
+select
+  created
+from ${TelemetryTable.WAL}
+where tableId = ${id} 
+and (event = 105 or event = 103)
+and latency != null
+limit -1
+`
diff --git a/packages/web-console/src/scenes/Editor/Metrics/utils.ts b/packages/web-console/src/scenes/Editor/Metrics/utils.ts
index 3183205d3..4d7178a3b 100644
--- a/packages/web-console/src/scenes/Editor/Metrics/utils.ts
+++ b/packages/web-console/src/scenes/Editor/Metrics/utils.ts
@@ -13,8 +13,6 @@ export const metricTypeLabel: Record<MetricType, string> = {
 }
 
 export enum MetricDuration {
-  TEN_MINUTES = "10min",
-  THIRTY_MINUTES = "30min",
   ONE_HOUR = "1h",
   THREE_HOURS = "3h",
   SIX_HOURS = "6h",
@@ -31,8 +29,6 @@ export enum SampleBy {
 }
 
 export const durationInMinutes: Record<MetricDuration, number> = {
-  [MetricDuration.TEN_MINUTES]: 10,
-  [MetricDuration.THIRTY_MINUTES]: 30,
   [MetricDuration.ONE_HOUR]: 60,
   [MetricDuration.THREE_HOURS]: 60 * 3,
   [MetricDuration.SIX_HOURS]: 60 * 6,
@@ -43,8 +39,6 @@ export const durationInMinutes: Record<MetricDuration, number> = {
 }
 
 export const mappedSampleBy: Record<MetricDuration, SampleBy> = {
-  [MetricDuration.TEN_MINUTES]: SampleBy.ONE_MINUTE,
-  [MetricDuration.THIRTY_MINUTES]: SampleBy.ONE_MINUTE,
   [MetricDuration.ONE_HOUR]: SampleBy.ONE_MINUTE,
   [MetricDuration.THREE_HOURS]: SampleBy.ONE_MINUTE,
   [MetricDuration.SIX_HOURS]: SampleBy.ONE_MINUTE,
@@ -68,6 +62,10 @@ export type Latency = {
   avg_latency: string
 }
 
+export type LastNotNull = {
+  created: string
+}
+
 export const minutesToDays = (durationInMinutes: number) =>
   durationInMinutes / 60 / 24
 
@@ -75,10 +73,6 @@ export const minutesToHours = (durationInMinutes: number) =>
   durationInMinutes / 60
 
 export const xAxisFormat = {
-  [MetricDuration.TEN_MINUTES]: (rawValue: number) =>
-    utcToLocal(rawValue, "HH:mm:ss"),
-  [MetricDuration.THIRTY_MINUTES]: (rawValue: number) =>
-    utcToLocal(rawValue, "HH:mm:ss"),
   [MetricDuration.ONE_HOUR]: (rawValue: number) =>
     utcToLocal(rawValue, "HH:mm"),
   [MetricDuration.THREE_HOURS]: (rawValue: number) =>