Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support typst #31

Open
cscheid opened this issue Sep 20, 2023 · 4 comments · May be fixed by #36
Open

Support typst #31

cscheid opened this issue Sep 20, 2023 · 4 comments · May be fixed by #36
Assignees

Comments

@cscheid
Copy link
Contributor

cscheid commented Sep 20, 2023

We got a question on out typst talk today about typst support for icons. This extension should support it. There's typst code for fontawesome here: https://github.com/matchy233/typst-chi-cv-template/blob/main/fontawesome.typ

We should make this all work.

@cscheid cscheid self-assigned this Sep 20, 2023
@cderv
Copy link
Contributor

cderv commented Sep 21, 2023

Related issue on typst to follow

Someone made a typst library for it for now: https://github.com/duskmoon314/typst-fontawesome (it is findable in search list at https://typst.app/docs/packages/). They have nice syntax and lots of icons it seems: https://typst.app/project/rQwGUWt5p33vrsb_uNPR9F

I just learnt about this experimental package repo: https://github.com/typst/packages
Really cool to see all this available!

elipousson added a commit to elipousson/fontawesome that referenced this issue Jan 28, 2024
@cderv cderv linked a pull request Jan 29, 2024 that will close this issue
@elipousson
Copy link

I made some progress on this but I'm not very familiar with Lua so I think I may still be missing some issues. I was able to implement support for relative sizes (e.g. "2xs" to "2xl"), limited support for groups ("brands" group only), and colored fill.

Unfortunately, while these all work for inline shortcodes—the shortcodes in the table from the example don't render as expected. In addition, the shortcode errors when used with LaTeX sizes ("tiny" to "Huge") and the literal sizes for HTML ("1x" to "10x"). The latter issues seem solvable (I'm just unsure how) but the first issue has me stumped. The shortcode also worked in tables before I implemented the group parameter!

Tips or suggestions of changes to try are welcome.

@elipousson
Copy link

I just made a few updates to the PR:

  • Fixed the issue with icon rendering so they work in tables as well as inline
  • Added support for LaTeX sizes ("tiny" to "Huge")
  • Renamed the fill argument to color for consistent with Added support for color (?) #35
  • Updated the example document to document the format-specific parameters

Literal sizes for HTML ("1x" to "10x") are still not handled well and color-handling could be improved but it is coming together. No rush to review @cscheid but just wanted to make sure you saw this existed.

@cscheid
Copy link
Contributor Author

cscheid commented Feb 21, 2024

@elipousson we're a bit swamped right now as you have noticed. I'll get to it when I can.

@Aariq Aariq mentioned this issue Sep 6, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants