Client Generator: Custom config-key with minus (-) get translated to underscore (_) in the generated code.

[ddelbondio]

If a custom config-key setting is used, the value of config-key gets its "-" replaced with "_".

Example:

quarkus.openapi-generator.codegen.spec.my_json-config-key=my-api

results in

@RegisterRestClient(baseUri="...", configKey="my_api")

[ricardozanini]

Hi! Thanks for reporting it. Can you open a PR to fix it? It should be reasonably straightforward. The key might follow the same rules for name sanitization we use for the OpenAPI ID.

[ddelbondio]

Sure, will have a look. Earliest next week though.

[mcruzdev]

Hi @ricardozanini, @hbelmiro actually with config-key feature we can use by example:

quarkus.openapi-generator.codegen.spec.my_json.config-key=my-api
quarkus.openapi-generator.codegen.spec.my-api.base-package=com.quarkiverse

quarkus-openapi-generator/client/deployment/src/main/java/io/quarkiverse/openapi/generator/deployment/codegen/OpenApiConfigValidator.java

Line 21 in ec6919d

"quarkus\\.openapi-generator\\.codegen\\.(spec.(?<specId>\\w*)\\.)?(?<configName>[A-Za-z0-9_\\-]*)\\.?(?<configMap>.+)?");

Looking the regex above, the only allowed specId is my_api not my-api. Thinking here, this group only allows alphanumeric + _ because the file is sanitized.

@ddelbondio I think you have two solutions:

• To add - to regex
• To receive the list of configured config-key values and to check it on that method.

Guys, any suggestions?

[ricardozanini]

@mcruzdev I think it's reasonable to have the - added to the regexp in case of a custom config like this. 🤔

[mcruzdev]

cc: @SergioRuyDev