fix(spi): Change unsupported class types in RetryConfig #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was discovered whilst trying a fix for another issue and refactoring the repository and moving spi classes to runtime. In runtime the Quarkus annotation processor is applied. And it was failing because of this incorrect configuration interface. This interface was written using the fields of the `org.eclipse.microprofile.faulttolerance.Retry` annotation. And one can set `Class` object as type of fields of annotation. It is however not supported by `microprofile-config`. This will have no effect as such, as those configuration entries are directly injected as configuration entries linked to the retryable method of `io.quarkiverse.kafkastreamsprocessor.impl.decorator.processor.RetryDecoratorDelegate`.
edeweerd1A
assigned vietk, tryasta, rquinio1A, flazarus1A, lmartella1, bsoaressimoes, csemaan1A and afatnassi1a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was discovered whilst trying a fix for another issue and refactoring the repository and moving spi classes to runtime. In runtime the Quarkus annotation processor is applied. And it was failing because of this incorrect configuration interface.
This interface was written using the fields of the
org.eclipse.microprofile.faulttolerance.Retryannotation. And one can setClassobject as type of fields of annotation. It is however not supported bymicroprofile-config.This will have no effect as such, as those configuration entries are directly injected as configuration entries linked to the retryable method of
io.quarkiverse.kafkastreamsprocessor.impl.decorator.processor.RetryDecoratorDelegate.