Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove normalisation = "all" option from textstat_valence #21

Open
kbenoit opened this issue Feb 13, 2023 · 0 comments
Open

Remove normalisation = "all" option from textstat_valence #21

kbenoit opened this issue Feb 13, 2023 · 0 comments

Comments

@kbenoit
Copy link
Contributor

kbenoit commented Feb 13, 2023

This scores any word not found in the dictionary as 0, in averaging the word values. This doesn't make any sense, because valences may have scales that do not include zero. So while AFINN has 0 in between its -5 to +5 scale, ANEW is scored 1-9. It makes no real sense to normalise over all token counts, since that's the same as assigning non-dictionary matches a zero.

Better to just allow normalisation to be switched off, and users can apply their own normalisations if they prefer. So keep "none" but make the default "dictionary" and 99% of users will want that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant