File Watcher Issues

[ayesaac]

Tools.WorkingDayService/src/Tools.WorkingDayService/FileSource/FileNonWorkingDaySource.cs

Line 44 in 87eb230

_fileWatcher = new FileSystemWatcher(filePath);

[ayesaac]

File Watcher will also not work without enabling events.

Suggested change:

_fileWatcher = new FileSystemWatcher(
    Path.GetDirectoryName(filePath) ?? string.Empty,
    Path.GetFileName(filePath));
{
    EnableRaisingEvents = true,
};

[ayesaac]

The file watcher's current event handler will fail when the file is modified in-place with most text editors, due to file locking issues.

The implementation should be updated to handle failures and attempt to retry:

https://github.com/qphl/order-manager/blob/master/orders-service/Permissions/JsonFilePermissionRepository.cs
https://github.com/qphl/pharmaxo-patient-management/blob/d4305bd388db9931baab81684254bad03a2c4cf5/src/PharmaxoPatientManagement/PharmaxoPatientManagement.WebModulesHost/WebModulesHostBootstrapper.cs#L484