From 21c47a27443fbc787e37afb16c523104ff05cabf Mon Sep 17 00:00:00 2001 From: Vincent Scavinner Date: Tue, 14 Nov 2023 16:29:10 +0100 Subject: [PATCH 1/2] feat: drop support for Node 16 --- .github/workflows/lint.yml | 4 ++-- .github/workflows/release.yml | 2 +- .github/workflows/test.yml | 6 +++--- package.json | 2 +- test-app/package.json | 2 +- 5 files changed, 8 insertions(+), 8 deletions(-) diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index f0c12a8d..110a32b2 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -23,7 +23,7 @@ jobs: uses: wyvox/action-setup-pnpm@v3 with: pnpm-version: 8.5.1 - node-version: 16.x + node-version: 18.x args: "--frozen-lockfile" - name: Run Lint run: pnpm lint @@ -46,7 +46,7 @@ jobs: - name: Install pnpm uses: wyvox/action-setup-pnpm@v3 with: - node-version: 16.x + node-version: 18.x args: "--frozen-lockfile" - name: Update TS version on addon package run: pnpm add -D ${{ matrix.typescript-scenario }} diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 6bdbb507..033987ee 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -17,7 +17,7 @@ jobs: uses: wyvox/action-setup-pnpm@v3 with: pnpm-version: 8.5.1 - node-version: 16 + node-version: 18.x node-registry-url: "https://registry.npmjs.org" - name: Build addon run: pnpm build diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index ff32b05c..8a0b27f0 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -24,7 +24,7 @@ jobs: uses: wyvox/action-setup-pnpm@v3 with: pnpm-version: 8.5.1 - node-version: 16.x + node-version: 18.x args: "--frozen-lockfile" - name: Test run: pnpm test:ember @@ -57,7 +57,7 @@ jobs: uses: wyvox/action-setup-pnpm@v3 with: pnpm-version: 8.5.1 - node-version: 16.x + node-version: 18.x args: "--frozen-lockfile" - name: Test run: pnpm ember try:one ${{ matrix.ember-try-scenario }} --skip-cleanup @@ -77,7 +77,7 @@ jobs: uses: wyvox/action-setup-pnpm@v3 with: pnpm-version: 8.5.1 - node-version: 16.x + node-version: 18.x args: "--no-lockfile" - name: Test run: pnpm test:ember diff --git a/package.json b/package.json index 5d1e75e6..7dcd1333 100644 --- a/package.json +++ b/package.json @@ -27,7 +27,7 @@ "release-it": "16.2.1" }, "engines": { - "node": "16.* || >= 18" + "node": ">= 18" }, "volta": { "node": "18.18.2" diff --git a/test-app/package.json b/test-app/package.json index 11958025..75861b4a 100644 --- a/test-app/package.json +++ b/test-app/package.json @@ -92,7 +92,7 @@ "webpack": "5.89.0" }, "engines": { - "node": "16.* || >= 18" + "node": ">= 18" }, "ember": { "edition": "octane" From 9d5c72d4160bf3c21336cc36867fad359652d539 Mon Sep 17 00:00:00 2001 From: Vincent Scavinner Date: Tue, 14 Nov 2023 16:29:18 +0100 Subject: [PATCH 2/2] doc: add Node compatibility information --- README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/README.md b/README.md index c919bab5..e5ed6e8e 100644 --- a/README.md +++ b/README.md @@ -23,6 +23,7 @@ ember install ember-phone-input - Ember CLI v2.13 or above - ember-auto-import v2 or above (ember-phone-input@6 is compatible with previous versions of ember-auto-import) +- Node.js v18 or above - TypeScript v5.0 or above ## Contributing