From e69b0f57ce48ca555ee5ea3622ac6794fbd6b2ba Mon Sep 17 00:00:00 2001 From: Vincent Scavinner Date: Mon, 6 Nov 2023 16:54:24 +0100 Subject: [PATCH] chore: install and use @qonto/eslint-config-typescript@1.0.0-rc.0 --- ember-phone-input/.eslintrc.cjs | 62 +-------------------------------- ember-phone-input/package.json | 1 + pnpm-lock.yaml | 21 +++++++++++ test-app/.eslintrc.js | 62 +-------------------------------- test-app/package.json | 1 + 5 files changed, 25 insertions(+), 122 deletions(-) diff --git a/ember-phone-input/.eslintrc.cjs b/ember-phone-input/.eslintrc.cjs index 6dda5326..2bae47d0 100644 --- a/ember-phone-input/.eslintrc.cjs +++ b/ember-phone-input/.eslintrc.cjs @@ -48,67 +48,7 @@ module.exports = { // ts files { files: ['**/*.ts'], - extends: [ - 'plugin:@typescript-eslint/eslint-recommended', - 'plugin:@typescript-eslint/recommended' - ], - rules: { - // https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/configs/recommended.ts - '@typescript-eslint/no-explicit-any': 'error', - '@typescript-eslint/no-non-null-assertion': 'error', - '@typescript-eslint/no-unused-vars': 'error', - // https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/configs/strict.ts - '@typescript-eslint/array-type': [ - 'error', - { - default: 'array', - readonly: 'array' - } - ], - '@typescript-eslint/ban-tslint-comment': 'error', - '@typescript-eslint/class-literal-property-style': 'error', - '@typescript-eslint/consistent-generic-constructors': 'error', - '@typescript-eslint/consistent-indexed-object-style': 'error', - '@typescript-eslint/consistent-type-assertions': 'error', - '@typescript-eslint/consistent-type-definitions': 'error', - '@typescript-eslint/consistent-type-imports': 'error', - '@typescript-eslint/explicit-function-return-type': 'error', - '@typescript-eslint/explicit-member-accessibility': [ - 'error', - { - accessibility: 'no-public' - } - ], - '@typescript-eslint/explicit-module-boundary-types': 'error', - '@typescript-eslint/member-delimiter-style': 'error', - '@typescript-eslint/member-ordering': 'error', - '@typescript-eslint/method-signature-style': 'error', - '@typescript-eslint/no-confusing-non-null-assertion': 'error', - '@typescript-eslint/no-duplicate-enum-values': 'error', - '@typescript-eslint/no-dynamic-delete': 'error', - '@typescript-eslint/no-extraneous-class': 'error', - '@typescript-eslint/no-import-type-side-effects': 'error', - '@typescript-eslint/no-invalid-void-type': 'error', - '@typescript-eslint/no-non-null-asserted-nullish-coalescing': 'error', - '@typescript-eslint/no-require-imports': 'error', - '@typescript-eslint/no-type-alias': [ - 'error', - { - allowGenerics: 'always' - } - ], - '@typescript-eslint/no-unsafe-declaration-merging': 'error', - '@typescript-eslint/parameter-properties': 'error', - '@typescript-eslint/prefer-enum-initializers': 'error', - '@typescript-eslint/prefer-for-of': 'error', - '@typescript-eslint/prefer-function-type': 'error', - '@typescript-eslint/prefer-literal-enum-member': 'error', - '@typescript-eslint/prefer-ts-expect-error': 'error', - '@typescript-eslint/sort-type-constituents': 'error', - '@typescript-eslint/type-annotation-spacing': 'error', - '@typescript-eslint/typedef': 'error', - '@typescript-eslint/unified-signatures': 'error' - } + extends: ['@qonto/eslint-config-typescript'] } ] }; diff --git a/ember-phone-input/package.json b/ember-phone-input/package.json index d40864bd..ef75cd93 100644 --- a/ember-phone-input/package.json +++ b/ember-phone-input/package.json @@ -63,6 +63,7 @@ "@glint/core": "1.2.1", "@glint/environment-ember-loose": "1.2.1", "@glint/template": "1.2.1", + "@qonto/eslint-config-typescript": "1.0.0-rc.0", "@rollup/plugin-babel": "6.0.4", "@tsconfig/ember": "3.0.2", "@types/intl-tel-input": "18.1.3", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index c0a96c2d..132d5d45 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -72,6 +72,9 @@ importers: '@glint/template': specifier: 1.2.1 version: 1.2.1 + '@qonto/eslint-config-typescript': + specifier: 1.0.0-rc.0 + version: 1.0.0-rc.0(eslint@8.53.0)(typescript@5.2.2) '@rollup/plugin-babel': specifier: 6.0.4 version: 6.0.4(@babel/core@7.23.2)(rollup@3.29.4) @@ -163,6 +166,9 @@ importers: '@glint/template': specifier: 1.2.1 version: 1.2.1 + '@qonto/eslint-config-typescript': + specifier: 1.0.0-rc.0 + version: 1.0.0-rc.0(eslint@8.53.0)(typescript@5.2.2) '@tsconfig/ember': specifier: 3.0.2 version: 3.0.2 @@ -3000,6 +3006,21 @@ packages: config-chain: 1.1.13 dev: true + /@qonto/eslint-config-typescript@1.0.0-rc.0(eslint@8.53.0)(typescript@5.2.2): + resolution: {integrity: sha512-laAtWhbOEaJH/Rq649bDM4gUW1OfVMNOgKe1Fg1R0/pCCmQgQ6AP0dz97Yj390HvHC4EDwiaPh8c7+agL/KY8A==} + engines: {node: '>= 18.*'} + peerDependencies: + eslint: ^7.0.0 || ^8.0.0 + typescript: '*' + dependencies: + '@typescript-eslint/eslint-plugin': 6.9.1(@typescript-eslint/parser@6.9.1)(eslint@8.53.0)(typescript@5.2.2) + '@typescript-eslint/parser': 6.9.1(eslint@8.53.0)(typescript@5.2.2) + eslint: 8.53.0 + typescript: 5.2.2 + transitivePeerDependencies: + - supports-color + dev: true + /@release-it-plugins/lerna-changelog@6.0.0(release-it@16.2.1): resolution: {integrity: sha512-/1xNLriHKKTdM+/LSQIng5V25gipw0brAXtWVQcOBR63NmW/Ftnd2IJpnM5WzFkOCcL9hoqc8rcIMMv1EOcaIg==} engines: {node: '>= 16'} diff --git a/test-app/.eslintrc.js b/test-app/.eslintrc.js index 369536a1..6a00eb33 100644 --- a/test-app/.eslintrc.js +++ b/test-app/.eslintrc.js @@ -54,67 +54,7 @@ module.exports = { // ts files { files: ['**/*.ts'], - extends: [ - 'plugin:@typescript-eslint/eslint-recommended', - 'plugin:@typescript-eslint/recommended' - ], - rules: { - // https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/configs/recommended.ts - '@typescript-eslint/no-explicit-any': 'error', - '@typescript-eslint/no-non-null-assertion': 'error', - '@typescript-eslint/no-unused-vars': 'error', - // https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/src/configs/strict.ts - '@typescript-eslint/array-type': [ - 'error', - { - default: 'array', - readonly: 'array' - } - ], - '@typescript-eslint/ban-tslint-comment': 'error', - '@typescript-eslint/class-literal-property-style': 'error', - '@typescript-eslint/consistent-generic-constructors': 'error', - '@typescript-eslint/consistent-indexed-object-style': 'error', - '@typescript-eslint/consistent-type-assertions': 'error', - '@typescript-eslint/consistent-type-definitions': 'error', - '@typescript-eslint/consistent-type-imports': 'error', - '@typescript-eslint/explicit-function-return-type': 'error', - '@typescript-eslint/explicit-member-accessibility': [ - 'error', - { - accessibility: 'no-public' - } - ], - '@typescript-eslint/explicit-module-boundary-types': 'error', - '@typescript-eslint/member-delimiter-style': 'error', - '@typescript-eslint/member-ordering': 'error', - '@typescript-eslint/method-signature-style': 'error', - '@typescript-eslint/no-confusing-non-null-assertion': 'error', - '@typescript-eslint/no-duplicate-enum-values': 'error', - '@typescript-eslint/no-dynamic-delete': 'error', - '@typescript-eslint/no-extraneous-class': 'error', - '@typescript-eslint/no-import-type-side-effects': 'error', - '@typescript-eslint/no-invalid-void-type': 'error', - '@typescript-eslint/no-non-null-asserted-nullish-coalescing': 'error', - '@typescript-eslint/no-require-imports': 'error', - '@typescript-eslint/no-type-alias': [ - 'error', - { - allowGenerics: 'always' - } - ], - '@typescript-eslint/no-unsafe-declaration-merging': 'error', - '@typescript-eslint/parameter-properties': 'error', - '@typescript-eslint/prefer-enum-initializers': 'error', - '@typescript-eslint/prefer-for-of': 'error', - '@typescript-eslint/prefer-function-type': 'error', - '@typescript-eslint/prefer-literal-enum-member': 'error', - '@typescript-eslint/prefer-ts-expect-error': 'error', - '@typescript-eslint/sort-type-constituents': 'error', - '@typescript-eslint/type-annotation-spacing': 'error', - '@typescript-eslint/typedef': 'error', - '@typescript-eslint/unified-signatures': 'error' - } + extends: ['@qonto/eslint-config-typescript'] } ] }; diff --git a/test-app/package.json b/test-app/package.json index 038d1e2b..23de69c5 100644 --- a/test-app/package.json +++ b/test-app/package.json @@ -35,6 +35,7 @@ "@glint/core": "1.2.1", "@glint/environment-ember-loose": "1.2.1", "@glint/template": "1.2.1", + "@qonto/eslint-config-typescript": "1.0.0-rc.0", "@tsconfig/ember": "3.0.2", "@types/qunit": "2.19.7", "@typescript-eslint/eslint-plugin": "6.9.1",