From af08b5b31190bcf91156084f08834df0ab102b8f Mon Sep 17 00:00:00 2001
From: foxspy <xianliang.li@zilliz.com>
Date: Fri, 3 Jan 2025 14:28:53 +0800
Subject: [PATCH] enhance: Update Knowhere version (#38942)

Signed-off-by: xianliang.li <xianliang.li@zilliz.com>
---
 internal/core/thirdparty/knowhere/CMakeLists.txt | 2 +-
 tests/go_client/testcases/groupby_search_test.go | 2 --
 tests/python_client/testcases/test_search.py     | 2 +-
 3 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/internal/core/thirdparty/knowhere/CMakeLists.txt b/internal/core/thirdparty/knowhere/CMakeLists.txt
index 32192f16e3bee..6e7d78a4400fb 100644
--- a/internal/core/thirdparty/knowhere/CMakeLists.txt
+++ b/internal/core/thirdparty/knowhere/CMakeLists.txt
@@ -14,7 +14,7 @@
 # Update KNOWHERE_VERSION for the first occurrence
 milvus_add_pkg_config("knowhere")
 set_property(DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR} PROPERTY INCLUDE_DIRECTORIES "")
-set( KNOWHERE_VERSION 52c03030 )
+set( KNOWHERE_VERSION 1cb3f0e )
 set( GIT_REPOSITORY  "https://github.com/zilliztech/knowhere.git")
 message(STATUS "Knowhere repo: ${GIT_REPOSITORY}")
 message(STATUS "Knowhere version: ${KNOWHERE_VERSION}")
diff --git a/tests/go_client/testcases/groupby_search_test.go b/tests/go_client/testcases/groupby_search_test.go
index a1fab2bf76763..7ad196d633242 100644
--- a/tests/go_client/testcases/groupby_search_test.go
+++ b/tests/go_client/testcases/groupby_search_test.go
@@ -50,10 +50,8 @@ func genGroupByBinaryIndex(metricType entity.MetricType) []index.Index {
 
 func genUnsupportedFloatGroupByIndex() []index.Index {
 	idxIvfPq := index.NewIvfPQIndex(entity.L2, 128, 16, 8)
-	idxScann := index.NewSCANNIndex(entity.L2, 16, false)
 	return []index.Index{
 		idxIvfPq,
-		idxScann,
 	}
 }
 
diff --git a/tests/python_client/testcases/test_search.py b/tests/python_client/testcases/test_search.py
index 1a008acdd226c..acd7ac568bdf1 100644
--- a/tests/python_client/testcases/test_search.py
+++ b/tests/python_client/testcases/test_search.py
@@ -10610,7 +10610,7 @@ def test_search_group_by_unsupported_index(self, index):
                 3. search with group by
                 verify: the error code and msg
         """
-        if index in ["HNSW", "IVF_FLAT", "FLAT", "IVF_SQ8", "DISKANN"]:
+        if index in ["HNSW", "IVF_FLAT", "FLAT", "IVF_SQ8", "DISKANN", "SCANN"]:
             pass  # Only HNSW and IVF_FLAT are supported
         else:
             metric = "L2"