Regenerate primary key when making layer permanent if layer property set #58954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Respect the OnConvertFormatRegeneratePrimaryKey layer property when making a temporary layer permanent. This ensures that processing outputs which require primary key regeneration will correctly get new primary keys when they are initially run with a memory layer output, and then later that memory layer is made permanent Fixes qgis#58942
troopa81
reviewed
Oct 3, 2024
I tried but failed -- the whole logic is too heavily tied into the gui (eg the functions I need to test open dialogs requiring user intervention), and would require substantial refactoring in QgisApp to permit automated testing. |
troopa81
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Respect the OnConvertFormatRegeneratePrimaryKey layer property when
making a temporary layer permanent.
This ensures that processing outputs which require primary key
regeneration will correctly get new primary keys when they are
initially run with a memory layer output, and then later that
memory layer is made permanent
Fixes #58942