Remove mandatory sslmode variable when loading a PostGIS Layer

[cymed]

Feature description

Currently, when defining a Postgres connection in the data service config, one has to set an ssl mode (the Combobox does not allow NULL values). This can lead to problems when using multiple pg_service files on different user profiles with different ssl mode settings or when sharing projects across organisations. We should allow setting no sslmode.

Additional context

No response

[DelazJ]

Currently, when defining a Postgres connection in the data service config, one has to set an ssl mode (the Combobox does not allow NULL values).

@cymed what is the dialog you are referring to?

[cymed]

[DelazJ]

Isn't "disable" equivalent to not use the SSL mode?

[cymed]

no, it means to specifically not use SSL mode, overwriting i.e. a sslmode=verify-full on the pg service

[DelazJ]

And "prefer" neither works?
So the point would be to have this dialog not overwriting what is in the pg_service file, but the opposite: if an SSL mode is provided in pg_service then it takes precedence, and if not we use what is in the dialog. Not everyone uses a pg_service file, or change that parameter in it. Removing the option is propably not desirable for everyone.

[cymed]

And "prefer" neither works?

"prefer" allows not passing keys, which can be undesirable.

So the point would be to have this dialog not overwriting what is in the pg_service file, but the opposite: if an SSL mode is provided in pg_service then it takes precedence, and if not we use what is in the dialog. Not everyone uses a pg_service file, or change that parameter in it. Removing the option is propably not desirable for everyone.

We should allow to set or not set the sslmode.

[NyakudyaA]

On my side, if I define a service configuration, the SSL mode is not saved in the project file.

[cymed]

On my side, if I define a service configuration, the SSL mode is not saved in the project file.

On which OS? I am running on Windows with 3.34.11

[NyakudyaA]

MacOS Sequoia, QGIS 3.38.2

[ponceta]

This is the feedback I get here too :
teksi/wastewater#470 (comment)

When using a pg_service, connexion information should not be saved to the QGIS project (except service name of course). This should enable the user to define.

@cymed can you check that if you load a layer from a pg_service it works that way too?

[cymed]

@ponceta When loading a pg_service without defining sslmode in QGIS, it works just fine
However, people who don't use pg_service are glad about the option of defining the sslmode. I would like to be able to not define sslmode, as it overrides pg_service settings, but not make it mandatory.

[ponceta]

Actually you either have a project configured for pg_service use :

<layer-tree-layer 
checked="Qt::Checked" 
expanded="1"
id="accident_22adc163_cd99_4190_864f_df42ade4c75a" 
legend_exp="" 
legend_split_behavior="0" 
name="accident" 
patch_size="-1,-1" 
providerKey="postgres"
source="service='pg_qgep' -->PG SERVICE
key='obj_id' srid=21781 
type=Point 
checkPrimaryKeyUnicity='0' 
table=&quot;qgep_od&quot;.&quot;accident&quot; (situation_geometry)">

Or for a "direct connexion"

<layer-tree-layer 
checked="Qt::Checked"
expanded="1" 
id="accident_1bc2f213_9d43_45e7_9a73_95a75636cae9" 
legend_exp="" 
legend_split_behavior="0" 
name="accident" 
patch_size="-1,-1" 
providerKey="postgres"
source="dbname='qgep' --> direct connection
host=mysuperfunkyhost.qgis.ch --> direct connection
port=5432 --> direct connection
authcfg=mysuperconnectionname --> direct connection
key='obj_id' 
srid=21781 
type=Point 
checkPrimaryKeyUnicity='0' 
table=&quot;qgep_od&quot;.&quot;accident&quot; (situation_geometry)">

So including sslmode statement in pg_service configured project seems to be a non-sense.

But you can easily include it in your pg_configuration :