Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

testqgs3drendering: Add a test for shadows effect #58111

Closed
wants to merge 1 commit into from
Closed

testqgs3drendering: Add a test for shadows effect #58111

wants to merge 1 commit into from

Conversation

ptitjano
Copy link
Contributor

No description provided.

@ptitjano ptitjano added the 3D Relates to QGIS' 3D engine or rendering label Jul 15, 2024
@ptitjano ptitjano self-assigned this Jul 15, 2024
@github-actions github-actions bot added this to the 3.40.0 milestone Jul 15, 2024
@github-actions GitHub Actions
Copy link

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 9e61000)

@ptitjano ptitjano changed the title testqgs3drendering: Add a test for shadows effect WIP: testqgs3drendering: Add a test for shadows effect Jul 15, 2024
@ptitjano ptitjano marked this pull request as draft July 15, 2024 14:02
@ptitjano ptitjano changed the title WIP: testqgs3drendering: Add a test for shadows effect testqgs3drendering: Add a test for shadows effect Jul 15, 2024
@github-actions GitHub Actions
Copy link

Tests failed for Qt 5

One or more tests failed using the build from commit 9e61000

shadow_effect (testShadowEffect)

shadow_effect

Test failed at testShadowEffect at tests/src/3d/testqgs3drendering.cpp:1575

Rendered image did not match tests/testdata/control_images/3d/expected_shadow_effect/expected_shadow_effect.png (found 4170 pixels different)

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

@github-actions GitHub Actions
Copy link

Tests failed for Qt 6

One or more tests failed using the build from commit 9e61000

shadow_effect (testShadowEffect)

shadow_effect

Test failed at testShadowEffect at tests/src/3d/testqgs3drendering.cpp:1575

Rendered image did not match tests/testdata/control_images/3d/expected_shadow_effect/expected_shadow_effect.png (found 244768 pixels different)

The full test report (included comparison of rendered vs expected images) can be found here.

Further documentation on the QGIS test infrastructure can be found in the Developer's Guide.

nyalldawson
nyalldawson reviewed Jul 18, 2024
View reviewed changes
tests/src/3d/testqgs3drendering.cpp
delete mapSettings;
delete scene;

QGSVERIFYIMAGECHECK( "shadow_effect", "shadow_effect", img, QString(), 40, QSize( 0, 0 ), 2 );
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest using a solid color terrain here if possible -- it'd make it easier to see exactly what the test is checking

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I only opened this PR to check if the shadows effect works in qt6. I can't make it work locally and it doesn't work on the ci too. The shadows are not visible.

@ptitjano
Copy link
Contributor Author

@nyalldawson #58184

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 3, 2024

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Aug 3, 2024
@ptitjano ptitjano removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Aug 5, 2024
@github-actions GitHub Actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Aug 20, 2024
@ptitjano ptitjano removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Aug 20, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 4, 2024

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 4, 2024
@ptitjano ptitjano added testsuite Issue related to testsuite and removed stale Uh oh! Seems this work is abandoned, and the PR is about to close. labels Sep 4, 2024
@github-actions GitHub Actions
Copy link

The QGIS project highly values your contribution and would love to see this work merged! Unfortunately this PR has not had any activity in the last 14 days and is being automatically marked as "stale". If you think this pull request should be merged, please check

  • that all unit tests are passing

  • that all comments by reviewers have been addressed

  • that there is enough information for reviewers, in particular

    • link to any issues which this pull request fixes

    • add a description of workflows which this pull request fixes

    • add screenshots if applicable

  • that you have written unit tests where possible
    In case you should have any uncertainty, please leave a comment and we will be happy to help you proceed with this pull request.
    If there is no further activity on this pull request, it will be closed in a week.

@github-actions github-actions bot added the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 19, 2024
@ptitjano ptitjano removed the stale Uh oh! Seems this work is abandoned, and the PR is about to close. label Sep 24, 2024
@nyalldawson
Copy link
Collaborator

@ptitjano what's the status here? is this still a draft? if so, can we close till it's ready please?

@ptitjano
Copy link
Contributor Author

ptitjano commented Oct 3, 2024

@ptitjano what's the status here? is this still a draft? if so, can we close till it's ready please?

The shadows effect does not work in qt6. I tried to understand why but It looks like a very complicated issue. So, yes, let's close it at the moment.

@ptitjano ptitjano closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyalldawson nyalldawson nyalldawson left review comments

Assignees

@ptitjano ptitjano

Labels
3D Relates to QGIS' 3D engine or rendering testsuite Issue related to testsuite
Projects
None yet
Milestone
3.40.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ptitjano @nyalldawson