Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CMYK] Properties widget #58110

Merged
merged 8 commits into from
Jul 17, 2024
Merged

Conversation

troopa81
Copy link
Contributor

@troopa81 troopa81 commented Jul 15, 2024

Add CMYK project properties configuration widgets.

When loading and ICC profile, QGIS force color model to keep consistency between color model and color space.

ICC profile widget part is not visible if QGIS is not built with Qt 6.8.0 or greater (That maybe require to be clearly advertise it t

cmyk_widget
he changelog)

Funded by Bordeaux Métropole

@troopa81 troopa81 added Feature Print Layouts Related to QGIS Print Layouts, Atlas or Reporting frameworks labels Jul 15, 2024
@github-actions github-actions bot added this to the 3.40.0 milestone Jul 15, 2024
Copy link

github-actions bot commented Jul 15, 2024

🪟 Windows builds ready!

Windows builds of this PR are available for testing here. Debug symbols for this build are available here.

(Built from commit 48de201)

src/app/qgsprojectproperties.cpp Outdated Show resolved Hide resolved
src/app/qgsprojectproperties.cpp Outdated Show resolved Hide resolved
src/app/qgsprojectproperties.h Outdated Show resolved Hide resolved
@nyalldawson
Copy link
Collaborator

Code looks good!

I have two thoughts:

  1. I think the "style" tab is becoming a random mash of settings now. I think we should probably pull these new settings and the existing "Project Colors" list out into a new dedicated "Colors" tab.
  2. Do you think we should add a button to export the current profile to a file on disk? If eg a user shares a project with someone else, they may want to easily extract this profile to use for another project or in another application.

@troopa81
Copy link
Contributor Author

I have two thoughts:

Good points. Done. Screenshot has been updated

src/app/qgsprojectproperties.cpp Outdated Show resolved Hide resolved
src/app/qgsprojectproperties.cpp Show resolved Hide resolved
@nyalldawson nyalldawson merged commit aa08d68 into qgis:master Jul 17, 2024
30 checks passed
@zacharlie zacharlie added the Changelog Items that are queued to appear in the visual changelog - remove after harvesting label Sep 24, 2024
@qgis-bot
Copy link
Collaborator

@troopa81

This pull request has been tagged for the changelog.

  • The description will be harvested so please provide a "nearly-ready" text for the final changelog
  • If possible, add a nice illustration of the feature. Only the first one in the description will be harvested (GIF accepted as well)
  • If you can, it's better to give credits to your sponsor, see below for different formats.

You can edit the description.

Format available for credits
  • Funded by NAME
  • Funded by URL
  • Funded by NAME URL
  • Sponsored by NAME
  • Sponsored by URL
  • Sponsored by NAME URL

Thank you!

@zacharlie zacharlie added ChangelogHarvested This PR description has been harvested in the Changelog already. and removed Changelog Items that are queued to appear in the visual changelog - remove after harvesting labels Sep 24, 2024
@DelazJ DelazJ added the Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. label Oct 2, 2024
@qgis-bot
Copy link
Collaborator

qgis-bot commented Oct 2, 2024

@troopa81
This pull request has been tagged as requiring documentation.

A documentation ticket will be opened at https://github.com/qgis/QGIS-Documentation when this PR is merged.

Please update the description (not the comments) with helpful description and screenshot to help the work from documentors.
Also, any commit having [needs-doc] or [Needs Documentation] in will see its message pushed to the issue, so please be as verbose as you can.

Thank you!

@qgis-bot
Copy link
Collaborator

qgis-bot commented Oct 2, 2024

@troopa81
A documentation ticket has been opened at qgis/QGIS-Documentation#9289
It is your responsibility to visit this ticket and add as much detail as possible for the documentation team to correctly document this change.
Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ChangelogHarvested This PR description has been harvested in the Changelog already. Feature Needs Documentation When merging a labeled PR, an issue will be created in the Doc repo. Print Layouts Related to QGIS Print Layouts, Atlas or Reporting frameworks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants