Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to upload a new version of the experimental plugin #477

Open
alexbruy opened this issue Oct 17, 2024 · 4 comments
Open

Impossible to upload a new version of the experimental plugin #477

alexbruy opened this issue Oct 17, 2024 · 4 comments
Assignees
Labels
🕔 Size 2 Give me 2 hours and I will have it for you

Comments

@alexbruy
Copy link

It is now impossible to upload a new version of the experimental plugin, the error is

There were errors reading plugin package (please check also your plugin's metadata).
The 'experimental' flag in the form does not match the 'experimental' flag in the plugins package metadata.

However, the upload form clearly states

Check this box if this version is experimental, leave unchecked if it's stable. Please note that this field might be overridden by metadata (if present).

The metadata file HAS the experimental metadata flag set, however it seems that existing logic was broken recently and override it not working anymore. Please advertise such changes as they are breaking workflows.

@Xpirix
Copy link
Collaborator

Xpirix commented Oct 17, 2024

Hi @alexbruy,

Can you please provide the steps you took? I tested uploading experimental plugin versions three times and didn't encounter any errors: https://plugins.qgis.org/plugins/test_modul/#plugin-versions

EDIT: I've deleted the test plugin from the repository, please find below a screenshot:
image

Here are the steps I followed:

  1. Uploaded a test plugin (first as experimental, then deleted it, and then uploaded it again as non-experimental).
  2. Initialized a new version with experimental=True in the metadata.
  3. Uploaded the new version with the experimental option checked in the form.
  4. Initialized another version with experimental=True in the metadata.
  5. Uploaded this last version with the experimental option checked in the form.

AFAIK no changes have been made recently that would break any workflow on the website.

@Xpirix
Copy link
Collaborator

Xpirix commented Oct 17, 2024

I agree with you that the form description doesn't really match the expected workflow. I tested uploading a new experimental version without checking the Experimental checkbox and I got the error.

@alexbruy
Copy link
Author

It is simple:

  1. Have an experimental plugin
  2. Prepare a new version of the plugin
  3. Try to add new version by selecting plugin package and leaving everything else unchanged
  4. Got an error as in the first comment.

This worked before without any errors, I never had any issues uploading new versions of the plugins (be it experimental or not) and all data were taken from the metadata file.

@Xpirix Xpirix self-assigned this Oct 18, 2024
@Xpirix Xpirix added the 🕔 Size 2 Give me 2 hours and I will have it for you label Oct 18, 2024
@Xpirix Xpirix moved this to Todo in Lova Work Planning Oct 18, 2024
@Xpirix
Copy link
Collaborator

Xpirix commented Oct 18, 2024

Thank you for the clarification. I will take a look into the issue further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕔 Size 2 Give me 2 hours and I will have it for you
Projects
Status: This sprint
Development

No branches or pull requests

2 participants