Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Token specification in sync_project.yml #242

Open
Steffengreiner opened this issue Dec 2, 2020 · 1 comment
Open

Missing Token specification in sync_project.yml #242

Steffengreiner opened this issue Dec 2, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@Steffengreiner
Copy link

Describe the bug

sync_project.yml doesn't specify the token during actions/checkout@v2 in the TEMPLATE Branches.
This leads to a termination of the Github action during the checkout process.

Expected behavior
Please specify the token in the 'actions/checkout@v2' step in the sync_project.yml for the template branch as follows:
token: '${{ secrets.JOHNNY_Q5_REPORTS_TOKEN }}'

Additional context
We noticed this in the data-model-lib Template Branch and SF fixed in on the master branch.

@Steffengreiner Steffengreiner added the bug Something isn't working label Dec 2, 2020
@Steffengreiner Steffengreiner changed the title Bug Summary Missing Token specification in sync_project.yml Dec 2, 2020
@sven1103
Copy link
Contributor

sven1103 commented Dec 2, 2020

That is the correct final layout:

name: Sync qube project

on:
  schedule:
    - cron: '0 1 * * *'
  workflow_dispatch:

jobs:
  build:
    runs-on: ubuntu-latest
    steps:
        - name: Setup Python
          uses: actions/setup-python@v1
          with:
            python-version: 3.8

        - name: Install qube
          run: pip install qube

        - uses: actions/checkout@v2
          with:
              fetch-depth: 0
              token: '${{ secrets.JOHNNY_Q5_REPORTS_TOKEN  }}'
          name: Check out source-code repository

        - uses: oleksiyrudenko/gha-git-credentials@v2-latest
          with:
              name: 'JohnnyQ5'
              email: '[email protected]'
              actor: 'JohnnyQ5'
              token: '${{ secrets.JOHNNY_Q5_REPORTS_TOKEN}}'

        - name: Sync project
          run: qube sync . ${{ secrets.JOHNNY_Q5_REPORTS_TOKEN  }} JohnnyQ5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants