Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase oleksiyrudenko/gha-git-credentials version #232

Merged
merged 1 commit into from
Nov 19, 2020
Merged

Increase oleksiyrudenko/gha-git-credentials version #232

merged 1 commit into from
Nov 19, 2020

Conversation

KochTobi
Copy link
Contributor

@KochTobi KochTobi commented Nov 19, 2020 •
edited
Loading

Solves #231

@KochTobi
Increase oleksiyrudenko/gha-git-credentials version
999e539 
Changes oleksiyrudenko/gha-git-credentials@v1 to oleksiyrudenko/gha-git-credentials@v2
@KochTobi KochTobi requested review from Zethson and a team November 19, 2020 14:40
Zethson
Zethson approved these changes Nov 19, 2020
View reviewed changes
Copy link
Collaborator

@Zethson Zethson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

Unfortunately you have to fix that manually for all other projects, since their sync will fail and they cannot correct it themselves.

One of the very rare cases where syncing breaks...

@KochTobi
Copy link
Contributor Author

Thanks :)

@KochTobi KochTobi linked an issue Nov 19, 2020 that may be closed by this pull request
Sync will break due to old set-env API -> upgrade git credentials GH actions from v1 to v2 #231
Open
@KochTobi KochTobi merged commit 50ca53a into development Nov 19, 2020
@KochTobi KochTobi deleted the fix/#400 branch November 19, 2020 14:45
@KochTobi
Copy link
Contributor Author

KochTobi commented Nov 19, 2020 •
edited
Loading

LGTM :)

Unfortunately you have to fix that manually for all other projects, since their sync will fail and they cannot correct it themselves.

One of the very rare cases where syncing breaks...

Where and how can I fix it manually? Do I remove the workflow? How is this done? @Zethson

@Zethson
Copy link
Collaborator

Zethson commented Nov 19, 2020

You look for this file https://github.com/qbicsoftware/qoffer-2-portlet/blob/master/.github/workflows/sync_project.yml (see here for qoffer2) and apply the same fix

https://github.com/qbicsoftware/qoffer-2-portlet/blob/master/.github/workflows/sync_project.yml#L26

v1 -> v2

Note that this should be done in the master branch.

@KochTobi
Copy link
Contributor Author

For the data-model-lib this does not work because the file is not on master. How can I proceed here?
The change is present in development

@Zethson
Copy link
Collaborator

Zethson commented Nov 19, 2020

That's fine. Just increase it in development.

@Zethson
Copy link
Collaborator

Zethson commented Nov 19, 2020

@KochTobi I wanted to comment here, but for some reason replied in the issue.

Anyways -> 2. answer is in the issue thread.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zethson Zethson Zethson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sync will break due to old set-env API -> upgrade git credentials GH actions from v1 to v2
2 participants
@KochTobi @Zethson