Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong date formatting leads to no changelog sections detected linting error #166

Open
Zethson opened this issue Sep 22, 2020 · 2 comments
Open

Wrong date formatting leads to no changelog sections detected linting error #166

Zethson opened this issue Sep 22, 2020 · 2 comments
Assignees
@sven1103 @Zethson
Labels
bug Something isn't working

Comments

@Zethson
Copy link
Collaborator

Zethson commented Sep 22, 2020 •
edited
Loading

Regarding changelog.rst:

(2020-07-31)

works

22-09-2020

does not.

We should catch the wrong date format earlier and return wrong date formatting as a linting error.
@Zethson Zethson added the bug Something isn't working label Sep 22, 2020
@KochTobi
Copy link
Contributor

@Zethson probably https://github.com/qbicsoftware/data-model-lib/blob/master/src/main/groovy/life/qbic/datamodel/Constants.groovy#L5
So I think the current setup should be fine @sven1103 ?

@Zethson
Copy link
Collaborator Author

Zethson commented Sep 25, 2020

@KochTobi Yeah, we discussed it.
Current setup is fine.

I'll keep this issue open to improve the linter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sven1103 sven1103

@Zethson Zethson

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sven1103 @KochTobi @Zethson