Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dealing with NativeOrNativeSourcesBuild logic in Quarkus extensions #26

Open
dgrove-oss opened this issue Feb 14, 2023 · 0 comments
Open

Comments

@dgrove-oss
Copy link
Contributor

dgrove-oss commented Feb 14, 2023

Many Quarkus extensions guard bits of their deployment logic with @BuildStep(onlyIf = NativeOrNativeSourcesBuild.class).

As a result, even though they are producing BuildItems we would like to consume (for example NativeImageResourceBuildItem), they are not activated just by us adding the quarkus-qbicc extension to the dependencies of a Quarkus application.

One place we are compensating for this via a kludge right now is
https://github.com/qbicc/quarkus-qbicc/blob/main/deployment/src/main/resources/qbicc-feature.yaml#L11-L14

In the short term, we probably need to adjust our plugin so we look like a native-sources packaging build.

Longer term, we need to discuss with the Quarkus team and see if it is possible to remove this idiom from their code base, or if it is something we will just need to cope with (most likely by continuing to masquarade as a native-sources packaging target).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant