Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get raw gene count tables from either Salmon and RSEM analysis #251

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

qbicStefanC
Copy link
Collaborator

@qbicStefanC qbicStefanC commented Nov 13, 2024

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Copy link

This PR is against the master branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @qbicStefanC,

It looks like this pull-request is has been made against the qbicStefanC/rnadeseq master branch.
The master branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to master are only allowed if they come from the qbicStefanC/rnadeseq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@qbicStefanC qbicStefanC changed the base branch from master to dev November 13, 2024 08:24
@qbicStefanC
Copy link
Collaborator Author

Hi @WackerO
I created this to get (back) the raw counts from the Salmon/RSEM paths inside rnadeseq. I think the changes in the file are abvious. I have tested it with a real project dataset (QTRRI) and with the test profile and made sure other files or results are unchanged. I think that part is fine . What I am still a bit unsure about is the extraction of the raw counts either how i did it with : assay(cds) or alternatively with counts(cds). In above mentioned project it did not make a difference but maybe once could test this again. Thanks,S

@WackerO
Copy link
Collaborator

WackerO commented Nov 19, 2024

Hello @qbicStefanC, thanks for the PR! I think the assay() function is fine.

It would be nice if you could update the test YMLs (https://github.com/qbic-pipelines/rnadeseq/blob/master/tests/test_star_salmon.yml and https://github.com/qbic-pipelines/rnadeseq/blob/master/tests/test_star_rsem.yml) by adding entries for the new matrices that are output; you just need to run those two tests (i.e. nextflow run main.nf -profile cfc,test_star_rsem and test_star_salmon) and generate the md5sums for the matrices.

Also, please update the https://github.com/qbic-pipelines/rnadeseq/blob/dev/CHANGELOG.md by copy-pasting an older entry to the top and modifying the line :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants