Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show unknown fields by default #23

Open
GollyTicker opened this issue Apr 18, 2022 · 1 comment
Open

Show unknown fields by default #23

GollyTicker opened this issue Apr 18, 2022 · 1 comment
Labels
enhancement New feature or request good-next-issue This issue is a good candidate for soon implementation

Comments

@GollyTicker
Copy link
Collaborator

When receiving a protobuf message of the wrong type (or specifying the wrong expected response type) often times no fields can be properly matched and the protobuf payload will be interpreted as empty. While we cannot guarantee to get an error in such a case, we can at least still show unknown fields which were present in the payload - and hence, make it easier for the user to detect, when they specified the wrong response type.
@GollyTicker GollyTicker added the enhancement New feature or request label Apr 18, 2022
@qa-swaneet-sahoo qa-swaneet-sahoo added the good-next-issue This issue is a good candidate for soon implementation label May 2, 2022
@GollyTicker
Copy link
Collaborator Author

Partially implemented in #52 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good-next-issue This issue is a good candidate for soon implementation
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GollyTicker @qa-swaneet-sahoo