Fix: network view flicker #632
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot! It works great! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The cause of this behavior resided in the
qaul_rpcpackage, which exposes aStateNotifier<List<User>>.On every second, we refresh the users list, so that the UI can be notified in case of new users or state changes for existing users.
This was causing the UI to re-render, since the list of users changed on every second (i.e. the object changed, not the actual list of users).
A state change notifies the UI to trigger a re-render, which is perceived as a flicker.
This is solved by not updating the notifier's state when it and the new list of users are deeply equal.