Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of max_nick_length is now possible #106

Open
llmII opened this issue Mar 5, 2021 · 0 comments · May be fixed by #109
Open

Removal of max_nick_length is now possible #106

llmII opened this issue Mar 5, 2021 · 0 comments · May be fixed by #109

Comments

@llmII
Copy link
Contributor

llmII commented Mar 5, 2021

Changing some things in the code base, can make use of go-ircevent's ISUPPORT parsing to pull out the NICKLEN ISUPPORT param and use that instead of having a configuration setting.

Key question here is... are there any IRC servers that don't report this ISUPPORT param.

The other question is should this be left in for vanity reasons such as "I don't like long nicks so I'm going to force discord puppets to have ones as short as possible!".
@llmII llmII changed the title Removal of max_nick_lenght is now possible Removal of max_nick_length is now possible Mar 5, 2021
llmII added a commit to llmII/go-discord-irc that referenced this issue Mar 5, 2021
@llmII
Cleanup: remove max_nick_length
e58253f 
This setting is no longer needed as the information can be gained via
the listener at runtime. This changes things to use go-ircevent's
ISUPPORT support instead of defining it in the config.

Closes qaisjp#106.
@llmII llmII linked a pull request Mar 5, 2021 that will close this issue
Open
llmII added a commit to llmII/go-discord-irc that referenced this issue Mar 6, 2021
@llmII
Cleanup: remove max_nick_length
d74cf45 
This setting is no longer needed as the information can be gained via
the listener at runtime. This changes things to use go-ircevent's
ISUPPORT support instead of defining it in the config.

Closes qaisjp#106.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup: remove max_nick_length llmII/go-discord-irc
1 participant
@llmII