Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Flake8 complaints and datetime imports #65

Merged
merged 3 commits into from
Apr 22, 2024

Conversation

pnuu
Copy link
Member

@pnuu pnuu commented Apr 22, 2024

This PR fixes flake8 complaints and fixes the datetime imports. This is a precursor work for #64

We can't do from datetime import datetime because it overwrites the module name thus making subsequent imports from datetime impossible.

@pnuu pnuu requested a review from mraspaud April 22, 2024 07:35
@pnuu pnuu self-assigned this Apr 22, 2024
Copy link

codecov bot commented Apr 22, 2024

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 79.90%. Comparing base (a28fb72) to head (be3bb77).
Report is 4 commits behind head on main.

❗ Current head be3bb77 differs from pull request most recent head bf2863b. Consider uploading reports for the commit bf2863b to get more accurate results

Files Patch % Lines
posttroll/logger.py 0.00% 2 Missing ⚠️
posttroll/__init__.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
+ Coverage   79.87%   79.90%   +0.03%     
==========================================
  Files          17       17              
  Lines        2211     2210       -1     
==========================================
  Hits         1766     1766              
+ Misses        445      444       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@mraspaud mraspaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, feel free to merge

@pnuu pnuu merged commit 963f621 into pytroll:main Apr 22, 2024
5 checks passed
@pnuu pnuu deleted the flake8-and-datetime-imports branch April 22, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants