Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

posttroll.listener should use hierarchical logger custom #67

Open
gerritholl opened this issue Oct 18, 2024 · 0 comments · May be fixed by #68
Open

posttroll.listener should use hierarchical logger custom #67

gerritholl opened this issue Oct 18, 2024 · 0 comments · May be fixed by #68

Comments

@gerritholl
Copy link
Member

It is customary in python logging for loggers to have dotted names up to at least the module level, such as posttroll.subscriber. This idiom is not respected by the posttroll.listener module, which calls its loggers ListenerContainer and Listener. Those should be called posttroll.listener.Listener and posttroll.listener.ListenerContainer, respectively, so that user applications can set a logging handler applying to all messages coming from posttroll, and don't need to configure an extra logger for Listener. Another advantage of respecting the logging idiom is that users can see what module is issuing a log message, something that is unclear in case of a bare Listener.

@pnuu pnuu linked a pull request Nov 15, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant