Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix triton attention bug #71

Closed
wants to merge 3 commits into from
Closed

Conversation

zhanglei1172
Copy link

The implementation of Triton does not carry out log2 scaling for bias, resulting in a large error. After correction, I can obtain an error with an absolute value <0.015 in my test here.

@facebook-github-bot
Copy link

Hi @zhanglei1172!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 18, 2023
@cpuhrsch
Copy link
Contributor

Thank you for the PR @zhanglei1172! Can you also add the test that you used to build this?

Just to make sure you won't think I forgot about this, I'm going to be on vacation until November 27th starting today. I'll review it again once I'm back! Thank you again for sending a PR!

@cpuhrsch
Copy link
Contributor

Hey @zhanglei1172 - I merged this as part of #108 . I was going to push to this pull request, but didn't want to push to your fork's main branch and interfere with something there. Thank yo for filing this PR and fixing the issue!

@cpuhrsch cpuhrsch closed this Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants