Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding "--" to argment list may change the argument of the program started by mprof run. #388

Open
lrtfm opened this issue Apr 3, 2023 · 2 comments · May be fixed by #390
Open

Adding "--" to argment list may change the argument of the program started by mprof run. #388

lrtfm opened this issue Apr 3, 2023 · 2 comments · May be fixed by #390

Comments

@lrtfm
Copy link

lrtfm commented Apr 3, 2023

Consider a program called test.py that may have an option -number -1. Command

mprof run python test.py -number -1

will pass -number -- -1 to test.py, i.e. test.py is started by

python test.py -number -- -1

It seems that the run action doesn't need -- to distinguish the parameters.
@suntong30
Copy link

I have the same issue.

@lrtfm lrtfm linked a pull request Apr 10, 2023 that will close this issue
Open
@lrtfm
Copy link
Author

lrtfm commented Apr 10, 2023

@StephQAZ To address this issue, you might want to consider using pull request #390.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Skip adding "--" for action "run" lrtfm/memory_profiler
2 participants
@lrtfm @suntong30