Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy support #35

Open
christophvw opened this issue Apr 23, 2021 · 3 comments
Open

Proxy support #35

christophvw opened this issue Apr 23, 2021 · 3 comments
Labels
enhancement good first issue

Comments

@christophvw
Copy link

As it looks like that requests-kerberos is dead it might be a good idea to adapt this patch to get proxy support here:
requests/requests-kerberos#148

When installing requests-gssapi I noticed the following:
Requirement already satisfied: urllib3!=1.25.0,!=1.25.1,<1.26,>=1.21.1

To get proper proxy support urlib3 >= 1.26 will be required.
@christophvw
Copy link
Author

#36

@frozencemetery
Copy link
Member

Note that requests-gssapi doesn't currently have a dependency on urllib3 directly. If it's important we could add one.

@christophvw
Copy link
Author

It looks like my patch works with http only, https failed in my tests. :/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frozencemetery @christophvw