Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR checks should require tests like they require docs #480

Open
iritkatriel opened this issue Nov 27, 2022 · 4 comments
Open

PR checks should require tests like they require docs #480

iritkatriel opened this issue Nov 27, 2022 · 4 comments
Labels
labels Issues related to GitHub label changes

Comments

@iritkatriel
Copy link
Member

tests are as standard a requirement as doc changes. New PR authors who are not aware of this could be helped by a check failing due to lack of tests (rather than waiting for someone to comment on that, which can take years in some cases).

So the suggestion is:

Any PR that touches code must also touch the tests, or have a skip-tests label.

@ezio-melotti ezio-melotti added the labels Issues related to GitHub label changes label Nov 28, 2022
@ezio-melotti
Copy link
Member

It might be better to move this to python/bedevere, since he is the one performing checks related to the skip-* labels.

@terryjreedy
Copy link
Member

AFAIK, there is no doc check/requirement, but I think there should be for enhancements. As I said on discord, I think we should at least try out both.

@hugovk
Copy link
Member

hugovk commented Nov 28, 2022

It might be better to move this to python/bedevere, since he is the one performing checks related to the skip-* labels.

At the sprint we talked about replacing some Bedevere functionality with more "native" GitHub stuff.

For example, this could be done with GitHub Actions.

@brettcannon Do you think https://github.com/brettcannon/check-for-changed-files would be suitable for this?

@brettcannon
Copy link
Member

Do you think https://github.com/brettcannon/check-for-changed-files would be suitable for this?

Yes because that's what I designed it for. 😁 See https://github.com/microsoft/vscode-python/blob/133a8e877aa3755eaf101f1f1edf446432770b40/.github/workflows/pr-file-check.yml#L34-L43 as an example usage for this exact use case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
labels Issues related to GitHub label changes
Projects
None yet
Development

No branches or pull requests

5 participants