Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ux: hide stack trace when solution exists (eg: SolverProblemError) #3040

Closed
abn opened this issue Oct 2, 2020 · 4 comments
Closed

ux: hide stack trace when solution exists (eg: SolverProblemError) #3040

abn opened this issue Oct 2, 2020 · 4 comments
Labels
area/ux Features and improvements related to the user experience kind/enhancement Not a bug or feature, but improves usability or performance

Comments

@abn
Copy link
Member

abn commented Oct 2, 2020

An error like this can be intimidating for users. and can lead to users believing that it is a crash and not an error. We should remove the stack trace in these cases unless -vvv is used.

Updating dependencies
Resolving dependencies... (0.1s)

  SolverProblemError

  Because turicreate (6.4.1) depends on coremltools (3.3)
   and  depends on coremltools (4.0b3), turicreate is forbidden.
  So, because  depends on turicreate (6.4.1), version solving failed.

  at ~/.poetry/lib/poetry/puzzle/solver.py:241 in _solve
      237│             packages = result.packages
      238│         except OverrideNeeded as e:
      239│             return self.solve_in_compatibility_mode(e.overrides, use_latest=use_latest)
      240│         except SolveFailure as e:
    → 241│             raise SolverProblemError(e)
      242│
      243│         results = dict(
      244│             depth_first_search(
      245│                 PackageNode(self._package, packages), aggregate_package_nodes

Example sourced from #3011

@abn abn added kind/enhancement Not a bug or feature, but improves usability or performance area/ux Features and improvements related to the user experience Good First Issue labels Oct 2, 2020
@lowitea
Copy link

lowitea commented Oct 6, 2020

Hi!
I have made a PR #3111
@abn could you please review it

@mpernigo
Copy link

mpernigo commented Oct 7, 2020

Hey! I was just starting to look into this. Let me know if I can help

@Secrus
Copy link
Member

Secrus commented Jun 4, 2022

Stack traces are now hidden by default

@Secrus Secrus closed this as completed Jun 4, 2022
Copy link

github-actions bot commented Mar 2, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/ux Features and improvements related to the user experience kind/enhancement Not a bug or feature, but improves usability or performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants