Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to PyQt5 #23

Open
nicluo opened this issue Dec 14, 2017 · 1 comment
Open

Upgrade to PyQt5 #23

nicluo opened this issue Dec 14, 2017 · 1 comment
Labels
enhancement

Comments

@nicluo
Copy link

nicluo commented Dec 14, 2017

Hi, I was trying to run this repo but it seems PyQt4 is no longer supported by the Qt company (I got Qt5 installed by default using the install steps). Link to PyQt about page.

I've upgraded the bindings to use PyQt5 imports, one of the bigger changes is switching from old-style signals to new-style signals. The commits are available on my fork and I can make a merge request if you want to.

nicluo@aa83fac
@pyskell
Copy link
Owner

pyskell commented Dec 15, 2017 •
edited
Loading

Awesome!

I'd be happy to merge this, just might require some updates to the README as well (as far as the Requirements and Dependencies sections). If you can update for the platforms you know about then it would be most appreciated. If not I'll make sure to get to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicluo @pyskell