Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: remove deprecated instruments from tests #39

Closed
3 tasks done
jklenzing opened this issue Oct 4, 2023 · 0 comments · Fixed by #40
Closed
3 tasks done

MAINT: remove deprecated instruments from tests #39

jklenzing opened this issue Oct 4, 2023 · 0 comments · Fixed by #40
Milestone
0.2.1 Release

Comments

@jklenzing
Copy link
Member

jklenzing commented Oct 4, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
pysat 3.2.0 will drop 3 instruments that are used in the tests here. They either represent redundancy or features that will no longer be supported.

Describe the solution you'd like

  • Drop tests for pysat_testing2d (no longer supported)
  • Replace pysat_testing_xarray with pysat_ndtesting
  • Replace pysat_testing_2dxarray with pysat_ndtesting

Describe alternatives you've considered
😴

Additional context
There may need to be some updates at pysat to make pysat_ndtesing a suitable replacement for pysat_testing_xarray needed to update tests so that profile size is not hard wired
@jklenzing jklenzing mentioned this issue Oct 4, 2023
Merged
10 tasks
@jklenzing jklenzing linked a pull request Oct 4, 2023 that will close this issue
MAINT: pysat deprecations #40
Merged
10 tasks
@jklenzing jklenzing added this to the 0.2.1 Release milestone Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.1 Release
Development

Successfully merging a pull request may close this issue.

MAINT: pysat deprecations pysat/pysatSeasons
1 participant
@jklenzing