Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipywidgets dependency #130

Closed
knaaptime opened this issue Feb 4, 2021 · 3 comments · Fixed by #132
Closed

ipywidgets dependency #130

knaaptime opened this issue Feb 4, 2021 · 3 comments · Fixed by #132

Comments

@knaaptime
Copy link
Member

following up on this issue revealed by the conda-forge CI (and graciously resolved by @ocefpaf) ipywidgets is a required dependency for splot.giddy. It would be a good idea if we moved ipywidgets to a function-level import here with an informative warning, or just made it a hard dependency
@knaaptime
Copy link
Member Author

knaaptime commented Feb 4, 2021 •
edited
Loading

i should add, im happy to PR if you let me know which alternative you prefer @slumnitz

@slumnitz
Copy link
Member

slumnitz commented Feb 4, 2021

Hello @knaaptime, I think the function level import is great idea. Thank you for helping.

This was referenced Jun 26, 2021
Closed
Merged
@martinfleis
Copy link
Member

Closed by #132

@slumnitz slumnitz mentioned this issue Jul 27, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

REF: make ipywidgets optional dependency
3 participants
@knaaptime @slumnitz @martinfleis