Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing for legendgrams? #7

Open
jGaboardi opened this issue Aug 26, 2018 · 4 comments
Open

testing for legendgrams? #7

jGaboardi opened this issue Aug 26, 2018 · 4 comments
Assignees
Labels

Comments

@jGaboardi
Copy link
Member

@ljwolf Should legendgram/test_legendgram.py be moved into a new tests/ directory?

@jGaboardi jGaboardi self-assigned this Aug 26, 2018
@ljwolf
Copy link
Member

ljwolf commented Aug 28, 2018

sure; better to be consistent. In theory, I'm fine with having small packages have no dedicated test directory, but there's no reason not to be consistent.

@ljwolf ljwolf closed this as completed Aug 28, 2018
@ljwolf ljwolf reopened this Aug 28, 2018
@ljwolf
Copy link
Member

ljwolf commented Apr 9, 2020

Further, as @martinfleis notes, we need to update the tests. pysal.contrib is over, and we need to use the standard geopandas tools to plot, I think.

@jGaboardi
Copy link
Member Author

  • since legendgram is moving to inside splot, should we work on updating the tests once it's in there?
  • @slumnitz, are you considering migrating splot testing from TravisCI to GitHub Actions? If yes, I can help out with that.

@jGaboardi
Copy link
Member Author

pysal.contrib is over, and we need to use the standard geopandas tools to plot, I think

geoplot from pysal.contrib.viz.mapping isn't even being used in the testing. Can we just remove that import in #11 ?

jGaboardi added a commit to ljwolf/legendgram that referenced this issue Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants