Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change name to match python naming #1

Open
asmodehn opened this issue Apr 3, 2017 · 4 comments
Open

Change name to match python naming #1

asmodehn opened this issue Apr 3, 2017 · 4 comments

Comments

@asmodehn
Copy link
Member

asmodehn commented Apr 3, 2017

This is because pyros structure has now changed to rely on namespace packages (from setuptools)

@asmodehn
Copy link
Member Author

this is not as simple as I thought before.

Normal packages are supported in python 2 and 3 and ROS deb packages
Namespace packages are supported in python 3 only (properly with PEP 420 which works with ROS as well) and ROS with python3.

We can probably rename our package to "pyros_interfaces_common" from kinetic, to have all interfaces packages with a proper prefix in package.
But maintaining a namespace package will be doable only when ROS will support python3 officially (still some way to go AFAIK...), so very likely in another distro, some time away in the future.

@asmodehn asmodehn changed the title From lunar : change name to match python naming Change name to match python naming Apr 19, 2017
@asmodehn
Copy link
Member Author

Or maybe we keep pyros_common as PyPI and pip name for now... even if we have 2 python packages named :

  • pyros_interfaces_common
  • pyros_interfaces_mock

And we will change package name only once, when we move to python3 and can support python namespace packages in deb pkgs.

@asmodehn
Copy link
Member Author

Everything seems to work properly with our current packaging naming :

$ pip list | grep pyros
pyros-common (0.4.2)
pyros-config (0.2.0)
pyros-interfaces-ros (0.4.0)
pyros-setup (0.2.1)
pyros-test (0.0.6)
pyros-utils (0.1.3)
$ python -c "import pyros_interfaces_common; print pyros_interfaces_common.__file__"
WARNING:root:ZMQ : Protobuf message implementation not found. Using pickle based protocol
/opt/ros/indigo/lib/python2.7/dist-packages/pyros_interfaces_common/__init__.pyc

@asmodehn
Copy link
Member Author

We now have a pyros_common package ,among the 3 others.

Renaming is on hold until we stabilize the structure of pyros, between "common" parts (code/data that will be serialized and passed around) and "interface" parts (code/data that stays in one process to interface).

The interface parts are currently splitted in two because we have a base class, but there may be better ways to do interfaces/facades in python...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant