-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Blending] Smoke Randomization Starting Point #11
base: main
Are you sure you want to change the base?
Conversation
Hi @jpennors , thnaks for your PR, can you fix the tests ? I'm looking at the code itself but you missing init files to make the package work properly |
I recommend adding the following code:
This will improve the mask by removing false detection like text in the corner for example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome @MateoLostanlen !
I did not know this lalelization package. It's actually working very well.
The code currently keeps the biggest label. We could have done it another way by picking the label which is the closest to the floor (meaning y=0). But I guess this is fine with our use cas 😄
@MateoLostanlen I got weird failing tests :
|
Create a module to get a random dx,dy starting point for smoke addition