Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix redirect error when calling cameras/ #383

Merged
merged 1 commit into from
Nov 1, 2024
Merged

Fix redirect error when calling cameras/ #383

merged 1 commit into from
Nov 1, 2024

Conversation

RonanMorgan
Copy link
Collaborator

Without this "/" there was a redirection to the port 80 (which was causing an error since it's not proxied)

According to this : fastapi/fastapi#9328
There is surely a proper solution if the HTTP headers are set up correctly, but I didn't succeed

@RonanMorgan RonanMorgan self-assigned this Oct 29, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.39%. Comparing base (0248df7) to head (ce7bf66).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #383   +/-   ##
=======================================
  Coverage   86.39%   86.39%           
=======================================
  Files          34       34           
  Lines         941      941           
=======================================
  Hits          813      813           
  Misses        128      128           
Flag Coverage Δ
backend 85.99% <ø> (ø)
client 92.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix!

@frgfm frgfm added the type: fix Something isn't working label Nov 1, 2024
@frgfm frgfm added this to the 0.2.0 milestone Nov 1, 2024
@frgfm frgfm merged commit f737b0d into main Nov 1, 2024
28 of 29 checks passed
@frgfm frgfm deleted the rs/fix-redirect branch November 1, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ext: client type: fix Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants