feat: send alert image with telegram message, if requested #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
August 11, 2023 18:42
- Dockerfile-dev: image FROM pyronear/pyro-api:python3.8-alpine3.10
- add boolean field send_message to recipient table - add int field media_id to notification table
|
Nice of you to open a PR 🙏 |
github-actions
bot
added
topic: build
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #279 +/- ##
==========================================
- Coverage 94.54% 94.31% -0.23%
==========================================
Files 63 66 +3
Lines 1594 1690 +96
==========================================
+ Hits 1507 1594 +87
- Misses 87 96 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/Dockerfile-dev
Outdated
| @@ -1,4 +1,4 @@ | |||
| FROM pyroapi:python3.8-alpine3.10 | |||
| FROM pyronear/pyro-api:python3.8-alpine3.10 | |||
There was a problem hiding this comment.
@blenzi your are changing this in severals PR it should be done once in a PR I guess
There was a problem hiding this comment.
Thanks @MateoLostanlen. Now that #281 was merged, this will be part of main
added 3 commits
December 5, 2023 16:24
# Conflicts: # poetry.lock # pyproject.toml # src/Dockerfile-dev
…ia_id to notification tables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the possibility to send the alert image together with a telegram message, if requested