Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import constants without DRMAA C library #59

Open
natefoo opened this issue Sep 5, 2017 · 4 comments
Open

Import constants without DRMAA C library #59

natefoo opened this issue Sep 5, 2017 · 4 comments

Comments

@natefoo
Copy link

natefoo commented Sep 5, 2017

In the application I develop on, we delay importing drmaa so that $DRMAA_LIBRARY_PATH can be set in the application config. We also map the state constants to corresponding strings.

We're going to be expanding that state mapping to include severity ordering, and I'm planning to wrap all of these (strings, severities, constants) up in a class so we can define comparison functions for the severity ordering and simplify state stringification.

That would be more easily done outside the scope of "DRMAA job runner" initialization linked above, but unfortunately, drmaa may not be importable outside of that scope. This leads me to two questions:

  1. Would it be possible to make drmaa.const importable without a libdrmaa? Or...
  2. Would you be interested in incorporating the higher level state wrapping I am planning to write for Galaxy directly in to the drmaa library?

I'm happy to submit a PR for either, if either sound good to you.

@dan-blanchard
Copy link
Contributor

@natefoo, as I've tried to make clear in other issues, I don't actually use this library anymore (because I don't use a DRMAA compatible cluster). I know many people find it useful (as I did when I was using the appropriate cluster), so I'm happy to review and merge PRs as necessary.

That said, let me answer your questions:

  1. That seems totally reasonable.
  2. I try to keep this library as system agnostic as possible, so a higher level wrapper for Galaxy should probably be a separate thing.

@natefoo
Copy link
Author

natefoo commented Sep 21, 2017

Ok, thanks for the heads up. Are you still planning on reviewing PRs or is this project looking for a maintainer?

@dan-blanchard
Copy link
Contributor

I'm still up for reviewing PRs until someone comes along who is interested in taking this over.

@natefoo
Copy link
Author

natefoo commented Sep 28, 2017

Sounds good. I might be interested at some point in the future especially if I had some reason why I needed to make some major changes or if you were no longer able to review PRs. Anyway, I'll PR my first suggestion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants