Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is h5py dependency required #148

Open
ramav87 opened this issue Apr 22, 2022 · 3 comments
Open

is h5py dependency required #148

ramav87 opened this issue Apr 22, 2022 · 3 comments
Assignees
@ssomnath @ramav87 @gduscher

Comments

@ramav87
Copy link
Contributor

ramav87 commented Apr 22, 2022

We may be able to remove the h5py dependency from sidpy. We should think about how best to go about doing this.
@ssomnath
Copy link
Member

Consider moving sidpy.hdf_utils to pyNSID and then having pyUSID import pyNSID. I am not particularly convinced about the benefits of the move. We may want to look into the benefits of removing h5py - is this going to be a major boon to users?

@gduscher
Copy link
Member

Made a branch without h5py which tests okay without h5py dependency.
I will try it out for some notebooks soon and report back

@ramav87
Copy link
Contributor Author

ramav87 commented May 6, 2023

@gduscher are we ready for a PR with removed h5py dependency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ssomnath ssomnath

@ramav87 ramav87

@gduscher gduscher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ssomnath @ramav87 @gduscher