Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can #include'd files be missing? #8

Open
NoahAmsel opened this issue Mar 3, 2021 · 0 comments
Open

Can #include'd files be missing? #8

NoahAmsel opened this issue Mar 3, 2021 · 0 comments

Comments

@NoahAmsel
Copy link
Contributor

NoahAmsel commented Mar 3, 2021

My C++ code depends on an external library, so I add the flag -I${nlohmann_SOURCE_DIR}/include to ensure that #include can find the headers. Now #include doesn't really need to work for pybind11_mkdoc to do its job, and indeed, if I do not add the flag -I${EXTERNAL_SOURCE_DIR}/include, pybind11_mkdoc still runs successfully. However, I get the following error message

fatal error: 'nlohmann/json_fwd.hpp' file not found

at the line where this file is #included. Can we eliminate this error message and guarantee to the user that pybind11_mkdoc works even if included files can't be found, or should we require that all #includes succeed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant