Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use numpy.typing.NDArray instead of np.ndarray #4512

Open
Saransh-cpp opened this issue Oct 14, 2024 · 3 comments · May be fixed by #4526
Open

Use numpy.typing.NDArray instead of np.ndarray #4512

Saransh-cpp opened this issue Oct 14, 2024 · 3 comments · May be fixed by #4526
Assignees
@sanjayh-2022
Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve

Comments

@Saransh-cpp
Copy link
Member

I noticed that pybamm uses np.ndarray everywhere, but we should use numpy.typing.NDArray wherever possible (everywhere). Ideally they should be swappable without any errors. Feel free to close this issue if there was a reason to specifically use np.ndarray.
@Saransh-cpp Saransh-cpp added difficulty: easy A good issue for someone new. Can be done in a few hours hacktoberfest priority: low No existing plans to resolve labels Oct 14, 2024
@sanjayh-2022
Copy link

I would like to work on this issue. Can i pick on this?

@agriyakhetarpal
Copy link
Member

Hi @sanjayh-2022, sure! Please let us know if you need any help with this.

This was referenced Oct 16, 2024
Closed
Open
@sanjayh-2022
Copy link

i have made the changes accordingly please review it .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sanjayh-2022 sanjayh-2022

Labels
difficulty: easy A good issue for someone new. Can be done in a few hours priority: low No existing plans to resolve
Projects
None yet
Milestone
No milestone
3 participants
@Saransh-cpp @agriyakhetarpal @sanjayh-2022