Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: pybamm.Simulation.set_parameters, pybamm.Simulation.set_up_and_parameterise_experiment and pybamm.Simulation.set_up_and_parameterise_model_for_experiment should be private (i.e. begin with underscore _) and not documented #3751

Closed
Akhil-Sharma30 opened this issue Jan 21, 2024 · 1 comment · Fixed by #4489
Closed

[Bug]: pybamm.Simulation.set_parameters, pybamm.Simulation.set_up_and_parameterise_experiment and pybamm.Simulation.set_up_and_parameterise_model_for_experiment should be private (i.e. begin with underscore _) and not documented #3751

Akhil-Sharma30 opened this issue Jan 21, 2024 · 1 comment · Fixed by #4489
Assignees
@Akhil-Sharma30
Labels
bug Something isn't working

Comments

@Akhil-Sharma30
Copy link
Contributor

PyBaMM Version

latest

Python Version

python3.11

Describe the bug

Took #3392, This is a part of API Docs in this issue.

Steps to Reproduce

Not applicable

Relevant log output

No response
@Akhil-Sharma30 Akhil-Sharma30 added the bug Something isn't working label Jan 21, 2024
@Akhil-Sharma30
Copy link
Contributor Author

I would like to work on this issue.

@Akhil-Sharma30 Akhil-Sharma30 mentioned this issue Jan 21, 2024
Closed
8 tasks
This was referenced Apr 9, 2024
Closed
Open
@Akhil-Sharma30 Akhil-Sharma30 mentioned this issue Oct 4, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Akhil-Sharma30 Akhil-Sharma30

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@Akhil-Sharma30