Skip to content

Commit

Permalink
Merge pull request #3452 from Saransh-cpp/release-workflow-fixes
Browse files Browse the repository at this point in the history
Make testpypi the default option (precaution) + update tag instructions
  • Loading branch information
Saransh-cpp authored Oct 20, 2023
2 parents 2c75354 + 881ee01 commit 00b1698
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .github/release_workflow.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,5 +75,5 @@ Some other essential things to check throughout the release process -
- As the release workflow is initiated by the `release` event, it's important to note that the default `GITHUB_REF` used by `actions/checkout` during the checkout process will correspond to the tag created during the release process. Consequently, the workflows will consistently build PyBaMM based on the commit associated with this tag. Should new commits be introduced to the `vYY.MM` branch, such as those addressing build issues, it becomes necessary to manually update this tag to point to the most recent commit -
```
git tag -f <tag_name> <commit_hash>
git push origin <tag_name> # can only be carried out by the maintainers
git push -f <pybamm-team/PyBaMM_remote_name> <tag_name> # can only be carried out by the maintainers
```
2 changes: 1 addition & 1 deletion .github/workflows/publish_pypi.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ on:
inputs:
target:
description: 'Deployment target. Can be "pypi" or "testpypi"'
default: "pypi"
default: "testpypi"
debug_enabled:
type: boolean
description: 'Run the build with tmate debugging enabled (https://github.com/marketplace/actions/debugging-with-tmate)'
Expand Down

0 comments on commit 00b1698

Please sign in to comment.