Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python 3.13 support #116

Closed
elliotgunton opened this issue Oct 9, 2024 · 4 comments
Closed

Python 3.13 support #116

elliotgunton opened this issue Oct 9, 2024 · 4 comments

Comments

@elliotgunton
Copy link
Contributor

elliotgunton commented Oct 9, 2024 •
edited
Loading

Hey @pwwang! Just creating an issue for awareness - I tried adding 3.13 to Hera's cicd argoproj-labs/hera#1232, but found the 3.13 job failing with the error: varname.utils.VarnameRetrievingError: Couldn't retrieve the call node. The same happens when running make ci locally.

It seems there's a compatibility issue with 3.13 for varname (as the rest of the Python versions work fine, so I don't think #107 applies). I can help investigate when I have time. Thanks!
@elliotgunton elliotgunton mentioned this issue Oct 9, 2024
Closed
pwwang added a commit that referenced this issue Oct 9, 2024
@pwwang
feat: support python 3.13 (#116)
91cb4d6
@pwwang
Copy link
Owner

pwwang commented Oct 9, 2024

Can you give v0.13.4 a try?

@elliotgunton
Copy link
Contributor Author

Hey, the new version has the same error (ci run here)

@pwwang
Copy link
Owner

pwwang commented Oct 11, 2024

Try v0.13.5.

@elliotgunton
Copy link
Contributor Author

Hey @pwwang, 0.13.5 looks good, thank you! argoproj-labs/hera#1232

@pwwang pwwang closed this as completed Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pwwang @elliotgunton