Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds PL translation #283

Merged
merged 2 commits into from
Sep 7, 2024

Conversation

lukaszlenart
Copy link

Closes #282

Corrected bug with Panic autoroll not working.
@pwatson100
Copy link
Owner

pwatson100 commented Jul 11, 2024

Hi Lukas, Have you pushed the correct file? The only items in Polish are the text that is used in the drop-down when an Actor is created.

Paul.

@lukaszlenart
Copy link
Author

I just started, the PR is draft and I will let you know once ready

@pwatson100
Copy link
Owner

Ok.

@lukaszlenart
Copy link
Author

It's done, yet I asked our friends to take a look as I probably made some mistakes :D

@pwatson100 pwatson100 changed the base branch from master to post-v12 September 7, 2024 08:56
@pwatson100 pwatson100 marked this pull request as ready for review September 7, 2024 08:56
@pwatson100 pwatson100 merged commit 795ac95 into pwatson100:post-v12 Sep 7, 2024
@pwatson100
Copy link
Owner

Lukasz,
Thank you for doing this. I have mergd it into my latest development branch (post-v12) and have noticed that as some of the words are longer than their Engklish counterparts its effecting the sheet formatting.
I was wondering if some of the could be abbreviated?
You should be able to download and install the post-v12 version to see what I mean.

@lukaszlenart lukaszlenart deleted the feature/pl-translation branch September 7, 2024 12:11
@lukaszlenart
Copy link
Author

I'm getting such error when trying to install using https://github.com/pwatson100/alienrpg/blob/post-v12/system.json
Screenshot 2024-09-07 at 14 24 52

@pwatson100
Copy link
Owner

Ah sorry , it cant be installed that way.
You need to switch to the branch and under <>Code tab download the zip file then create an alienrpg directory under system and unzip the file into it.

@lukaszlenart
Copy link
Author

I was able to review the package and notice some issues, I will prepare another PR addressing those

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polish translation
2 participants