Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/722 people skills controller cleanup #747

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feature/722 people skills controller cleanup #747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions app/controllers/people/people_skills_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,11 @@

class People::PeopleSkillsController < CrudController
include ParamConverters
self.permitted_attrs = [{ people_skills_attributes: [:id, :certificate, :level, :interest,
:core_competence, :skill_id, :unrated,
:_destroy] }]
before_action :set_person

def self.model_class
Person
end
self.permitted_attrs = [:id, :certificate, :level, :interest, :core_competence, :skill_id,
:unrated, :skill_ids, :_destroy, { skill_attributes:
[:id, :title, :radar, :portfolio, :default_set, :category_id] }]
self.nesting = Person
layout 'person'

def update
@people_skills = filtered_people_skills
Expand All @@ -28,10 +25,6 @@ def show_path

private

def set_person
@person = Person.find(params[:id])
end

def filtered_people_skills
return @person.people_skills if params[:rating].blank?

Expand Down
Loading